Skip to content

Commit 3e1bbb2

Browse files
Downgrade error logs to debug in memspaces and memtargets
They are misleadingly read as errors, while they are simply debug information that these targets aren't accessible on a machine.
1 parent 5d37cac commit 3e1bbb2

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

src/memspaces/memspace_highest_bandwidth.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ static void umfMemspaceHighestBandwidthInit(void) {
102102
umf_result_t ret =
103103
umfMemspaceHighestBandwidthCreate(&UMF_MEMSPACE_HIGHEST_BANDWIDTH);
104104
if (ret != UMF_RESULT_SUCCESS) {
105-
LOG_ERR(
105+
LOG_DEBUG(
106106
"Creating the highest bandwidth memspace failed with the error: %u",
107107
ret);
108108
assert(ret == UMF_RESULT_ERROR_NOT_SUPPORTED);

src/memspaces/memspace_lowest_latency.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ static void umfMemspaceLowestLatencyInit(void) {
9898
umf_result_t ret =
9999
umfMemspaceLowestLatencyCreate(&UMF_MEMSPACE_LOWEST_LATENCY);
100100
if (ret != UMF_RESULT_SUCCESS) {
101-
LOG_ERR(
101+
LOG_DEBUG(
102102
"Creating the lowest latency memspace failed with the error: %u",
103103
ret);
104104
assert(ret == UMF_RESULT_ERROR_NOT_SUPPORTED);

src/memtargets/memtarget_numa.c

+9-8
Original file line numberDiff line numberDiff line change
@@ -309,8 +309,8 @@ static umf_result_t query_attribute_value(void *srcMemoryTarget,
309309
int ret = hwloc_memattr_get_value(topology, hwlocMemAttrType, dstNumaNode,
310310
&initiator, 0, &memAttrValue);
311311
if (ret) {
312-
LOG_PERR("Getting an attribute value for a specific target NUMA node "
313-
"failed");
312+
LOG_PDEBUG("Getting an attribute value for a specific target NUMA node "
313+
"failed");
314314
return (errno == EINVAL) ? UMF_RESULT_ERROR_NOT_SUPPORTED
315315
: UMF_RESULT_ERROR_UNKNOWN;
316316
}
@@ -330,9 +330,10 @@ static umf_result_t numa_get_bandwidth(void *srcMemoryTarget,
330330
umf_result_t ret = query_attribute_value(srcMemoryTarget, dstMemoryTarget,
331331
bandwidth, MEMATTR_TYPE_BANDWIDTH);
332332
if (ret) {
333-
LOG_ERR("Retrieving bandwidth for initiator node %u to node %u failed.",
334-
((struct numa_memtarget_t *)srcMemoryTarget)->physical_id,
335-
((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
333+
LOG_DEBUG(
334+
"Retrieving bandwidth for initiator node %u to node %u failed.",
335+
((struct numa_memtarget_t *)srcMemoryTarget)->physical_id,
336+
((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
336337
return ret;
337338
}
338339

@@ -348,9 +349,9 @@ static umf_result_t numa_get_latency(void *srcMemoryTarget,
348349
umf_result_t ret = query_attribute_value(srcMemoryTarget, dstMemoryTarget,
349350
latency, MEMATTR_TYPE_LATENCY);
350351
if (ret) {
351-
LOG_ERR("Retrieving latency for initiator node %u to node %u failed.",
352-
((struct numa_memtarget_t *)srcMemoryTarget)->physical_id,
353-
((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
352+
LOG_DEBUG("Retrieving latency for initiator node %u to node %u failed.",
353+
((struct numa_memtarget_t *)srcMemoryTarget)->physical_id,
354+
((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
354355
return ret;
355356
}
356357

0 commit comments

Comments
 (0)