Fix error handling in file_open_ipc_handle()

ldorau · ldorau · commit dedfde13d4e9 · 2024-09-19T10:46:49.000+02:00
Fix error handling in file_open_ipc_handle().
It fixes the Coverity issue no. 469239.

Signed-off-by: Lukasz Dorau &lt;lukasz.dorau@intel.com&gt;
diff --git a/src/provider/provider_file_memory.c b/src/provider/provider_file_memory.c
@@ -582,7 +582,7 @@ static umf_result_t file_open_ipc_handle(void *provider, void *providerIpcData,
     }
 
     fd = os_file_open(file_ipc_data->path);
-    if (fd <= 0) {
+    if (fd == -1) {
         LOG_PERR("opening the file to be mapped (%s) failed",
                  file_ipc_data->path);
         return UMF_RESULT_ERROR_INVALID_ARGUMENT;

Original file line number	Diff line number	Diff line change
`@@ -582,7 +582,7 @@ static umf_result_t file_open_ipc_handle(void provider, void providerIpcData,`
`582`	`582`	`}`
`583`	`583`
`584`	`584`	`fd = os_file_open(file_ipc_data->path);`
`585`		`- if (fd <= 0) {`
	`585`	`+ if (fd == -1) {`
`586`	`586`	`LOG_PERR("opening the file to be mapped (%s) failed",`
`587`	`587`	`file_ipc_data->path);`
`588`	`588`	`return UMF_RESULT_ERROR_INVALID_ARGUMENT;`