Skip to content

Commit 7a3b09b

Browse files
joepiojoepio
committed
fix(drives): the private drive stops claiming to hold notifications
Both the badge tooltip and the share warning listed notifications among what the private drive holds. It does not: notifications are #1243, still unmerged. What is actually there is the saved-drives list (seeded in `ensurePersonalDrive`), favourites, and AI chats. Warning someone about data that does not exist teaches them to discount the warning, which is the one thing this copy cannot afford — it is the last thing between a private drive and being handed to a colleague.
1 parent 161904c commit 7a3b09b

6 files changed

Lines changed: 52 additions & 28 deletions

File tree

‎browser/data-browser/src/components/Drives/PrivateDriveBadge.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import type { JSX } from 'react';
1313
*/
1414
export function PrivateDriveBadge(): JSX.Element {
1515
return (
16-
<Badge title='This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project.'>
16+
<Badge title='This is your private drive. It holds your drive list, favourites and AI chats, and its address comes from your account — so there is only ever one, and it is not a place for a project.'>
1717
<FaLock />
1818
Private
1919
</Badge>

‎browser/data-browser/src/components/Share/ShareDialog.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,9 @@ export function ShareDialog({
116116
<FaTriangleExclamation />
117117
<span>
118118
This is your <strong>private drive</strong>. Sharing it
119-
shares your drive list, favourites, notifications and AI
120-
chats along with it. To work with someone, make a drive
121-
for the work and share that instead.
119+
shares your drive list, favourites and AI chats along with
120+
it. To work with someone, make a drive for the work and
121+
share that instead.
122122
</span>
123123
</PrivateDriveWarning>
124124
)}

‎browser/data-browser/src/locales/de.po‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7344,9 +7344,8 @@ msgstr ""
73447344
msgid "<0/> Private"
73457345
msgstr ""
73467346

7347-
#: src/components/Drives/PrivateDriveBadge.tsx
7348-
msgid "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7349-
msgstr ""
7347+
#~ msgid "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7348+
#~ msgstr ""
73507349

73517350
#: src/views/getting-started/GettingStartedFlow.tsx
73527351
msgid "Want a server of your own?"
@@ -7368,10 +7367,17 @@ msgstr ""
73687367
msgid "Drives"
73697368
msgstr ""
73707369

7371-
#: src/components/Share/ShareDialog.tsx
7372-
msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7373-
msgstr ""
7370+
#~ msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7371+
#~ msgstr ""
73747372

73757373
#: src/components/NewIdentitySection.tsx
73767374
msgid "Creating your private drive…"
73777375
msgstr ""
7376+
7377+
#: src/components/Drives/PrivateDriveBadge.tsx
7378+
msgid "This is your private drive. It holds your drive list, favourites and AI chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7379+
msgstr ""
7380+
7381+
#: src/components/Share/ShareDialog.tsx
7382+
msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7383+
msgstr ""

‎browser/data-browser/src/locales/en.po‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7378,9 +7378,8 @@ msgstr "Open a drive by URL or DID"
73787378
msgid "<0/> Private"
73797379
msgstr "<0/> Private"
73807380

7381-
#: src/components/Drives/PrivateDriveBadge.tsx
7382-
msgid "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7383-
msgstr "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7381+
#~ msgid "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7382+
#~ msgstr "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
73847383

73857384
#: src/views/getting-started/GettingStartedFlow.tsx
73867385
msgid "Want a server of your own?"
@@ -7402,10 +7401,17 @@ msgstr "run it yourself"
74027401
msgid "Drives"
74037402
msgstr "Drives"
74047403

7405-
#: src/components/Share/ShareDialog.tsx
7406-
msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7407-
msgstr "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7404+
#~ msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7405+
#~ msgstr "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
74087406

74097407
#: src/components/NewIdentitySection.tsx
74107408
msgid "Creating your private drive…"
74117409
msgstr "Creating your private drive…"
7410+
7411+
#: src/components/Drives/PrivateDriveBadge.tsx
7412+
msgid "This is your private drive. It holds your drive list, favourites and AI chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7413+
msgstr "This is your private drive. It holds your drive list, favourites and AI chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7414+
7415+
#: src/components/Share/ShareDialog.tsx
7416+
msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7417+
msgstr "This is your <0>private drive</0>. Sharing it shares your drive list, favourites and AI chats along with it. To work with someone, make a drive for the work and share that instead."

‎browser/data-browser/src/locales/es.po‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7344,9 +7344,8 @@ msgstr ""
73447344
msgid "<0/> Private"
73457345
msgstr ""
73467346

7347-
#: src/components/Drives/PrivateDriveBadge.tsx
7348-
msgid "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7349-
msgstr ""
7347+
#~ msgid "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7348+
#~ msgstr ""
73507349

73517350
#: src/views/getting-started/GettingStartedFlow.tsx
73527351
msgid "Want a server of your own?"
@@ -7368,10 +7367,17 @@ msgstr ""
73687367
msgid "Drives"
73697368
msgstr ""
73707369

7371-
#: src/components/Share/ShareDialog.tsx
7372-
msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7373-
msgstr ""
7370+
#~ msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7371+
#~ msgstr ""
73747372

73757373
#: src/components/NewIdentitySection.tsx
73767374
msgid "Creating your private drive…"
73777375
msgstr ""
7376+
7377+
#: src/components/Drives/PrivateDriveBadge.tsx
7378+
msgid "This is your private drive. It holds your drive list, favourites and AI chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7379+
msgstr ""
7380+
7381+
#: src/components/Share/ShareDialog.tsx
7382+
msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7383+
msgstr ""

‎browser/data-browser/src/locales/fr.po‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7344,9 +7344,8 @@ msgstr ""
73447344
msgid "<0/> Private"
73457345
msgstr ""
73467346

7347-
#: src/components/Drives/PrivateDriveBadge.tsx
7348-
msgid "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7349-
msgstr ""
7347+
#~ msgid "This is your private drive. It holds your drive list, favourites, notifications and chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7348+
#~ msgstr ""
73507349

73517350
#: src/views/getting-started/GettingStartedFlow.tsx
73527351
msgid "Want a server of your own?"
@@ -7368,10 +7367,17 @@ msgstr ""
73687367
msgid "Drives"
73697368
msgstr ""
73707369

7371-
#: src/components/Share/ShareDialog.tsx
7372-
msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7373-
msgstr ""
7370+
#~ msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites, notifications and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7371+
#~ msgstr ""
73747372

73757373
#: src/components/NewIdentitySection.tsx
73767374
msgid "Creating your private drive…"
73777375
msgstr ""
7376+
7377+
#: src/components/Drives/PrivateDriveBadge.tsx
7378+
msgid "This is your private drive. It holds your drive list, favourites and AI chats, and its address comes from your account — so there is only ever one, and it is not a place for a project."
7379+
msgstr ""
7380+
7381+
#: src/components/Share/ShareDialog.tsx
7382+
msgid "This is your <0>private drive</0>. Sharing it shares your drive list, favourites and AI chats along with it. To work with someone, make a drive for the work and share that instead."
7383+
msgstr ""

0 commit comments

Comments
 (0)