Agents stop update managedcluster status when clock is out of sync.

Signed-off-by: xuezhaojun <[email protected]>

Author: xuezhaojun

pkg/registration/hub/lease/clocksynccontroller.go

@@ -104,6 +104,7 @@ func (c *clockSyncController) sync(ctx context.Context, syncCtx factory.SyncCont
 	}
 	// When the agent's lease get renewed, the "now" on hub should close to the RenewTime on agent.
 	// If the two time are not close(over 1 lease duration), we assume the clock is out of sync.
+	// Then, if the Clock is out of sync, the agent will not be able to update the status of managed cluster.
 	oneLeaseDuration := time.Duration(LeaseDurationSeconds) * time.Second
 	if err := c.updateClusterStatusClockSynced(ctx, cluster,
 		now.Sub(observedLease.Spec.RenewTime.Time) < oneLeaseDuration && observedLease.Spec.RenewTime.Time.Sub(now) < oneLeaseDuration); err != nil {

pkg/registration/spoke/managedcluster/status_controller.go

@@ -121,6 +121,12 @@ func (c *managedClusterStatusController) sync(ctx context.Context, syncCtx facto
 		}
 	}
 
+	// check if managedcluster's clock is out of sync, if so, the agent will not be able to update the status of managed cluster.
+	clockSynced := meta.IsStatusConditionTrue(newCluster.Status.Conditions, clusterv1.ManagedClusterConditionClockSynced)
+	if !clockSynced {
+		return nil
+	}
+
 	changed, err := c.patcher.PatchStatus(ctx, newCluster, newCluster.Status, cluster.Status)
 	if err != nil {
 		errs = append(errs, err)