Skip to content

Commit 96b2c6b

Browse files
jarebudevaepfli
andauthored
feat!: moved sdk-contrib to JDK11 (#1303)
Signed-off-by: jarebudev <[email protected]> Co-authored-by: Simon Schrottner <[email protected]>
1 parent ab14cc1 commit 96b2c6b

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

.github/workflows/ci.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ jobs:
1616
build:
1717
- java: 21
1818
profile: codequality
19-
- java: 8
20-
profile: java8
19+
- java: 11
20+
profile: java11
2121

2222
name: with Java ${{ matrix.build.java }}
2323
runs-on: ${{ matrix.os}}

.sdkmanrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
java=8.0.312-tem
1+
java=11.0.26-tem

CONTRIBUTING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22

33
## System Requirements
44

5-
Java 8+ is required for the tooling, plugins, etc. Maven 3.8+ is recommended.
5+
Java 11+ is required for the tooling, plugins, etc. Maven 3.8+ is recommended.
66

77
## Compilation target(s)
88

9-
As in the Java-SDK, we target Java 8. The parent POM configures this automatically.
9+
As in the Java-SDK, we target Java 11. The parent POM configures this automatically.
1010

1111
## Adding a module
1212

pom.xml

+6-7
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
</surefireArgLine>
6363
<skip.tests>false</skip.tests>
6464
<!-- this will throw an error if we use APIs not available in the specified version -->
65-
<maven.compiler.release>8</maven.compiler.release>
65+
<maven.compiler.release>11</maven.compiler.release>
6666
</properties>
6767

6868
<dependencyManagement>
@@ -292,8 +292,7 @@
292292
</excludePackageNames>
293293
<doclint>all,-missing
294294
</doclint> <!-- ignore missing javadoc, these are enforced with more customizability in the checkstyle plugin -->
295-
296-
<source>8</source>
295+
<legacyMode>true</legacyMode>
297296
</configuration>
298297
<executions>
299298
<execution>
@@ -529,14 +528,14 @@
529528
</build>
530529
</profile>
531530

532-
<!-- profile for running tests under java 8 (used mostly in CI) -->
531+
<!-- profile for running tests under java 11 (used mostly in CI) -->
533532
<!-- selected automatically by JDK activeation (see https://maven.apache.org/guides/introduction/introduction-to-profiles.html#implicit-profile-activation) -->
534533
<profile>
535-
<id>java8</id>
536-
<!-- with the next block we can define a set of artifacts which still support java 8, if any of the artifacts is not supporting java 8 anymore -->
534+
<id>java11</id>
535+
<!-- with the next block we can define a set of artifacts which still support java 11, if any of the artifacts is not supporting java 11 anymore -->
537536
<!--<modules><module></module></modules>-->
538537
<properties>
539-
<toolchain.jdk.version>(1.8,9)</toolchain.jdk.version>
538+
<toolchain.jdk.version>[11,)</toolchain.jdk.version>
540539
<skip.tests>true</skip.tests>
541540
</properties>
542541

0 commit comments

Comments
 (0)