🚧 [#5139] Replace DataContainer with FormioData instance in is_visible_in_frontend

Author: viktorvanwijk

src/openforms/formio/utils.py

@@ -334,7 +334,7 @@ def is_visible_in_frontend(component: Component, data: DataMapping) -> bool:
     if not (trigger_component_key := conditional.get("when")):
         return not hidden
 
-    trigger_component_value = glom(data, trigger_component_key, default=None)
+    trigger_component_value = data.get(trigger_component_key)
     compare_value = conditional.get("eq")
 
     if (

src/openforms/submissions/form_logic.py

@@ -146,7 +146,7 @@ def evaluate_form_logic(
     data_diff = FormioData()
     for component in config_wrapper:
         key = component["key"]
-        is_visible = config_wrapper.is_visible_in_frontend(key, data_container.data)
+        is_visible = config_wrapper.is_visible_in_frontend(key, FormioData(data_container.data_without_to_python))
         if is_visible:
             continue
 

src/openforms/submissions/tests/form_logic/test_modify_components.py

@@ -874,6 +874,40 @@ def test_component_visible_in_frontend(self):
             "Some data that must not be cleared!", submission_step.data["textField"]
         )
 
+    def test_component_visible_with_date(self):
+        form = FormFactory.create()
+        form_step = FormStepFactory.create(
+            form=form,
+            form_definition__configuration={
+                "components": [
+                    {
+                        "key": "date",
+                        "type": "date",
+                    },
+                    {
+                        "type": "textfield",
+                        "key": "textField",
+                        "hidden": True,
+                        "conditional": {"eq": "2025-01-01", "show": True, "when": "date"},
+                        "clearOnHide": True,
+                    },
+                ]
+            },
+        )
+
+        submission = SubmissionFactory.create(form=form)
+        submission_step = SubmissionStepFactory.create(
+            submission=submission,
+            form_step=form_step,
+            data={"date": "2025-01-01", "textField": "Some data that must not be cleared!"},
+        )
+
+        evaluate_form_logic(submission, submission_step, submission.data, dirty=True)
+
+        self.assertEqual(
+            "Some data that must not be cleared!", submission_step.data["textField"]
+        )
+
     @tag("gh-1183")
     def test_component_incomplete_frontend_logic(self):
         form = FormFactory.create()