fix(playwright): scope the guardrail rules to TypeScript and enforce it

The playwright rule globs were inherited as {js,jsx,ts,tsx}. Nothing in the
corpus is JavaScript — all 245 baselined files are .ts — but the glob pulled
in the new CommonJS plugin under eslint-rules/, applying test rules like
no-positional-locator to the linter's own source. That is also why the CI
bypass-guard grep had to be restricted to .ts/.tsx: the plugin's RuleTester
fixtures contain literal eslint-disable strings it would match.

Narrow the four rule globs to {ts,tsx}. The plugin keeps its own CommonJS
block, so its source is still linted, just not as a Playwright test. The
suppressions baseline is byte-identical.

Scoping alone would trade one gap for another: Playwright's default
testMatch collects *.spec.js, so a JavaScript spec would run with no rules
applied at all. Verified directly — a planted .spec.js is collected as
'[chromium] > Features/__ExtCheck.spec.js'. So the TypeScript-only property
the scoping relies on is now asserted in corpus.test.js rather than assumed,
and fails with the offending paths if a .js/.jsx ever lands in the corpus.

Author: ShaileshParmar11

openmetadata-ui/src/main/resources/ui/eslint.config.mjs

@@ -433,7 +433,7 @@ export default [
 
   // Playwright tests
   {
-    files: ['**/playwright/**/*.{js,jsx,ts,tsx}'],
+    files: ['**/playwright/**/*.{ts,tsx}'],
     plugins: {
       playwright,
       'om-playwright': omPlaywright,
@@ -523,7 +523,7 @@ export default [
 
   // Custom rules that only make sense on e2e spec files
   {
-    files: ['playwright/e2e/**/*.spec.{js,jsx,ts,tsx}'],
+    files: ['playwright/e2e/**/*.spec.{ts,tsx}'],
     plugins: {
       'om-playwright': omPlaywright,
     },
@@ -564,7 +564,7 @@ export default [
   // one (admin) perspective?" If yes, switch to the fixture. If no (you need
   // a second user), the warning is expected — leave it as-is.
   {
-    files: ['playwright/e2e/**/*.spec.{js,jsx,ts,tsx}'],
+    files: ['playwright/e2e/**/*.spec.{ts,tsx}'],
     rules: {
       'no-restricted-syntax': [
         'warn',
@@ -594,7 +594,7 @@ export default [
       'src/setupTests.js',
       'src/**/*.test.{js,jsx,ts,tsx}',
       'src/**/*.spec.{js,jsx,ts,tsx}',
-      'playwright/**/*.spec.{js,jsx,ts,tsx}',
+      'playwright/**/*.spec.{ts,tsx}',
     ],
     rules: {
       '@typescript-eslint/no-require-imports': 'off',

openmetadata-ui/src/main/resources/ui/playwright/eslint-rules/tests/corpus.test.js

@@ -46,3 +46,49 @@ test('suppressions baseline only ever shrinks', () => {
     `suppression total ${total} exceeds ceiling ${CEILING} — fix the violations rather than suppressing them`
   );
 });
+
+// The 18 guardrail rules are scoped to `**/playwright/**/*.{ts,tsx}` in
+// eslint.config.mjs, deliberately: the local plugin under `eslint-rules/` is
+// CommonJS `.js` and is not a Playwright test, so applying test rules to it is
+// meaningless. That scoping only holds as a guardrail while the test corpus
+// really is TypeScript-only — Playwright's default `testMatch` DOES collect
+// `*.spec.js`, so a JavaScript spec would run with none of the rules applied.
+// This test makes the TypeScript-only invariant explicit rather than assumed.
+test('the playwright corpus stays TypeScript-only', () => {
+  const ROOT = path.join(__dirname, '../..');
+  // eslint-rules/ is the CommonJS plugin itself; doc-generator/ is lint-ignored
+  // tooling. Neither is a test, and neither is collected by Playwright.
+  const EXEMPT = new Set([
+    'eslint-rules',
+    'doc-generator',
+    'output',
+    'test-data',
+  ]);
+
+  const offenders = [];
+  const walk = (dir, relative) => {
+    for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
+      const rel = relative ? `${relative}/${entry.name}` : entry.name;
+
+      if (entry.isDirectory()) {
+        if (!EXEMPT.has(rel)) {
+          walk(path.join(dir, entry.name), rel);
+        }
+      } else if (/\.(js|jsx)$/.test(entry.name)) {
+        offenders.push(rel);
+      }
+    }
+  };
+
+  walk(ROOT, '');
+
+  assert.deepStrictEqual(
+    offenders,
+    [],
+    `JavaScript files found in the Playwright corpus: ${offenders.join(
+      ', '
+    )}. ` +
+      'Playwright collects *.spec.js but eslint.config.mjs scopes the guardrail ' +
+      'rules to .ts/.tsx, so these would run unlinted. Convert them to TypeScript.'
+  );
+});