Skip to content

Commit fdf2c61

Browse files
fix(ci): dedicated shard for IntakeFormCustomPropertyFields; drop non-existent IntakeForm project
Bumping the matrix to 8 with `--shard=X/7` produced 6 idle shards (shards 3-8 each finished in ~11s with 0 tests) because co-listing `--project=chromium --project=IntakeFormCustomPropertyFields` under `--shard` collapses distribution: IntakeFormCustomPropertyFields depends on the entire chromium project and is `fullyParallel: false`, so Playwright pins the work to shard 1/N. Same problem showed up in the previous 5-shard runs as shard 2 timing out at 194 min. Split the workload so every matrix slot does real work: - shard 1: DataAssetRules (unchanged) - shard 2: IntakeFormCustomPropertyFields on its own project - shards 3-8: `--project=chromium --shard=X/6` (6 chromium shards) Also drop `--project=IntakeForm` — that project does not exist on 1.13 (only `IntakeFormCustomPropertyFields` was added by #30910); Playwright was silently accepting the unknown name. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 2668762 commit fdf2c61

1 file changed

Lines changed: 14 additions & 6 deletions

File tree

.github/workflows/postgresql-nightly-e2e.yml

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,16 +88,24 @@ jobs:
8888
--project=DataAssetRulesEnabled \
8989
--project=DataAssetRulesDisabled
9090
91+
elif [ "${{ matrix.shardIndex }}" -eq "2" ]; then
92+
echo "🔹 Running IntakeFormCustomPropertyFields on shard 2"
93+
94+
# IntakeFormCustomPropertyFields depends on the chromium project and
95+
# is fullyParallel: false. Co-listing it with chromium under --shard
96+
# collapses distribution onto shard 1/N and leaves the other shards
97+
# empty, so it must run on its own matrix slot.
98+
npx playwright test \
99+
--project=IntakeFormCustomPropertyFields
100+
91101
else
92-
# Shards 2-7 handle chromium tests (7 shards total)
93-
CHROMIUM_SHARD=$(( ${{ matrix.shardIndex }} - 1 ))
94-
echo "🔹 Running all tests (excluding DataAssetRules) on chromium shard ${CHROMIUM_SHARD}/5"
102+
# Shards 3-8 handle chromium tests (6 shards total)
103+
CHROMIUM_SHARD=$(( ${{ matrix.shardIndex }} - 2 ))
104+
echo "🔹 Running all tests (excluding DataAssetRules) on chromium shard ${CHROMIUM_SHARD}/6"
95105
npx playwright test \
96106
--project=chromium \
97-
--project=IntakeFormCustomPropertyFields \
98-
--project=IntakeForm \
99107
--grep-invert @dataAssetRules \
100-
--shard=${CHROMIUM_SHARD}/7
108+
--shard=${CHROMIUM_SHARD}/6
101109
fi
102110
103111
env:

0 commit comments

Comments
 (0)