Add empty placeholder for asset and custom property - #30528
Conversation
✅ Playwright Results — workflow succeededValidated commit ✅ 909 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 152 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 42m 33s ⏱️ Max setup 2m 55s · max shard execution 18m 59s · max shard-job elapsed before upload 22m 16s · reporting 6s 🌐 194.17 requests/attempt · 2.48 app boots/UI scenario · 21.77% common-shard skew Optimization targets still in progress:
🟡 1 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
…placeholder Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Code Review ✅ ApprovedAdds redesigned empty-state placeholders for asset tabs and custom-property tables, including localized labels and updated Playwright test specs. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source |



Describe your changes:
Fixed all Playwright test failures that were caused by the No Data placeholder changes.
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Summary by Gitar
AssetsTabscomponentCustomPropertyTablecomponent to useCreatePlaceholderwith actions and custom descriptionsThis will update automatically on new commits.
Greptile Summary
Adds redesigned empty-state placeholders for linked assets and custom properties, including localized descriptions and actions.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Reviews (13): Last reviewed commit: "fix lint issue" | Re-trigger Greptile