Skip to content

Add empty placeholder for asset and custom property - #30528

Merged
anuj-kumary merged 15 commits into
mainfrom
empty-placeholder-asset
Jul 28, 2026
Merged

Add empty placeholder for asset and custom property#30528
anuj-kumary merged 15 commits into
mainfrom
empty-placeholder-asset

Conversation

@anuj-kumary

@anuj-kumary anuj-kumary commented Jul 27, 2026

Copy link
Copy Markdown
Member

Describe your changes:

Fixed all Playwright test failures that were caused by the No Data placeholder changes.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • UI Enhancements:
    • Added empty asset placeholder icon and updated AssetsTabs component
    • Updated CustomPropertyTable component to use CreatePlaceholder with actions and custom descriptions
  • Localization:
    • Added new locale keys for empty assets and custom properties across multiple language files

This will update automatically on new commits.

Greptile Summary

Adds redesigned empty-state placeholders for linked assets and custom properties, including localized descriptions and actions.

  • Adds an empty-asset illustration and entity-specific placeholder copy.
  • Maps team asset placeholders to the correct localized team noun and adds unit coverage.
  • Updates related classification styling, translations, and Playwright coverage.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
openmetadata-ui/src/main/resources/ui/src/components/Glossary/GlossaryTerms/tabs/AssetsTabs.component.tsx Replaces the generic empty-assets message with an entity-aware CreatePlaceholder and fixes the previously reported Team wording through the updated helper.
openmetadata-ui/src/main/resources/ui/src/utils/Assets/AssetsUtils.tsx Adds an explicit Team mapping to getEntityTypeString, resolving the prior fallback to the data-product label.
openmetadata-ui/src/main/resources/ui/src/utils/Assets/AssetsUtils.test.ts Adds focused coverage for entity label mappings, including the corrected Team behavior.
openmetadata-ui/src/main/resources/ui/src/components/common/CustomPropertyTable/CustomPropertyTable.tsx Updates the empty custom-property presentation to use the shared actionable placeholder.
openmetadata-ui/src/main/resources/ui/src/locale/languages/en-us.json Adds source strings for the new asset and custom-property empty states.

Reviews (13): Last reviewed commit: "fix lint issue" | Re-trigger Greptile

@anuj-kumary anuj-kumary self-assigned this Jul 27, 2026
@anuj-kumary anuj-kumary added the safe to test Add this label to run secure Github workflows on PRs label Jul 27, 2026
@anuj-kumary
anuj-kumary requested a review from a team as a code owner July 27, 2026 12:57
@anuj-kumary anuj-kumary added the skip-pr-checks Bypass PR metadata validation check label Jul 27, 2026
@github-actions github-actions Bot added the UI UI specific issues label Jul 27, 2026
Rohit0301
Rohit0301 previously approved these changes Jul 27, 2026
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.67% (76800/116937) 49.55% (46115/93067) 50.76% (13892/27366)

Rohit0301
Rohit0301 previously approved these changes Jul 27, 2026
@anuj-kumary
anuj-kumary enabled auto-merge (squash) July 27, 2026 13:48
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit 8fa3f2ce5e8d6a4cb1cecbaff6e433d4aabcd492 in Playwright run 30347166948, attempt 1.

✅ 909 passed · ❌ 0 failed · 🟡 1 flaky · ⏭️ 152 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 42m 33s

⏱️ Max setup 2m 55s · max shard execution 18m 59s · max shard-job elapsed before upload 22m 16s · reporting 6s

🌐 194.17 requests/attempt · 2.48 app boots/UI scenario · 21.77% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 21.77% (convergence target: at most 15%).
  • Application boot ratio was 2.48 per UI scenario (2375 boots / 956 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 165 0 0 54 0 0
✅ Shard chromium-02 160 0 0 29 0 0
✅ Shard chromium-03 136 0 0 55 0 0
✅ Shard chromium-04 135 0 0 12 0 0
🟡 Shard chromium-05 175 0 1 0 0 0
✅ Shard data-asset-rules-01 61 0 0 0 0 0
✅ Shard domain-isolation-01 14 0 0 0 0 0
✅ Shard global-state-01 23 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 10 0 0 0 0 0
✅ Shard search-rbac-01 27 0 0 2 0 0
🟡 1 flaky test(s) (passed on retry)
  • Pages/Entity.spec.tsDomain Propagation (shard chromium-05, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

…placeholder

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
harsh-vador
harsh-vador previously approved these changes Jul 28, 2026
@anuj-kumary
anuj-kumary added this pull request to the merge queue Jul 28, 2026
@anuj-kumary
anuj-kumary removed this pull request from the merge queue due to a manual request Jul 28, 2026
siddhant1
siddhant1 previously approved these changes Jul 28, 2026
@anuj-kumary
anuj-kumary enabled auto-merge July 28, 2026 06:26
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
siddhant1
siddhant1 previously approved these changes Jul 28, 2026
Rohit0301
Rohit0301 previously approved these changes Jul 28, 2026
harsh-vador
harsh-vador previously approved these changes Jul 28, 2026
@sonarqubecloud

Copy link
Copy Markdown

@gitar-bot

gitar-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds redesigned empty-state placeholders for asset tabs and custom-property tables, including localized labels and updated Playwright test specs. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar | Powered by Gitar — free for open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants