Skip to content

Bulk edit silently drops tags after the antd Button migration #30941

Description

@chirag-madlani

Summary

After the antd Buttonui-core-components migration (#30810), a tag selected
in the bulk edit grid is never applied. The import runs and reports success,
but the tag is missing from the entity afterwards.

User impact: silent data loss. Someone bulk-editing assets sets a tag, sees no
error, and the tag simply isn't there.

Evidence

From the Playwright trace of DataAssetRulesDisabled.spec.tsBulk Edit Actions
→ Database service
:

  • The bulk edit does run — both importAsync?dryRun=true (preview) and
    importAsync?dryRun=false (apply) fire.
  • Sensitive appears only in a JS bundle and the tag-search response. It
    never appears in the import payload.
  • The post-edit screenshot shows the service with empty Tags and Tier.

So the tag is chosen in the dropdown but never committed into the grid cell, and
the CSV is built without it.

Confirmed a regression, not flake

Same shards on #30780 (Typography, merged green) — same pipeline, same seeded
data, one commit earlier:

shard #30780
data-asset-rules-01 pass (10m56s)
ingestion-01 pass (15m14s)
ingestion-02 pass (17m59s)
reindex-01 pass (19m32s)

They fail on the Button branch consistently across two reruns of the same commit,
and pass on unrelated PRs (e.g. #30469, full 105-check run). One shard,
chromium-01, was genuinely flaky and now passes.

Ruled out (tested, not reasoned)

Where to look next

The commit path between selecting the tag and the grid cell holding it —
fillTagDetailsclickInlineSave (inline-save-btn) in
playwright/utils/importUtils.ts, against InlineEdit.component.tsx and the
bulk-edit grid's tag cell editor.

Note the e2e helper clicks with { force: true } because "grid cells and the
fixed import footer can overlap inline editors", so element geometry is worth
checking — core Button sizes differ from antd's (size="small"xs).

Reproduction

CI only. The dev server cannot render the bulk-edit grid locally (fails at
.rdg-header-row) even though CI gets well past that point, so local repro is
not currently faithful.

Failing run: https://github.com/open-metadata/OpenMetadata/actions/runs/30831595988

Status

#30810 is being merged into antd-migration/wave-1 with these three shards
knowingly red, so the wave is not blocked. This must be fixed before wave-1
reaches main.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Status
No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions