Skip to content

Migrate off of Makefile for Docker container relase #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jalseth opened this issue Feb 15, 2025 · 5 comments · Fixed by #1075 or #1082
Closed

Migrate off of Makefile for Docker container relase #1066

jalseth opened this issue Feb 15, 2025 · 5 comments · Fixed by #1075 or #1082
Assignees
@Amamgbu
Labels
docker Pull requests that update Docker code enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jalseth
Copy link
Member

jalseth commented Feb 15, 2025

Makefiles are a bit annoying to maintain, and Docker provides premade Github actions to make building and pushing the container images easier.

See plexsystems/konstraint@be7edd7 as inspiration
@jalseth jalseth added docker Pull requests that update Docker code enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 15, 2025
@jalseth jalseth changed the title Migraet off of Makefile for Docker container relase Migrate off of Makefile for Docker container relase Feb 15, 2025
@Amamgbu
Copy link
Contributor

Amamgbu commented Feb 17, 2025

Hi @jalseth
I would like to take this up

@Amamgbu Amamgbu mentioned this issue Feb 20, 2025
Merged
@Amamgbu
Copy link
Contributor

Amamgbu commented Feb 20, 2025

Hi @jalseth
I have submitted PR #1075 to address this issue by migrating Docker build and push from Makefile to pre-made GitHub Actions. Kindly review

@jalseth jalseth reopened this Mar 1, 2025
@jalseth
Copy link
Member Author

jalseth commented Mar 1, 2025

Reopening this, as the Makefile should have the push target removed since it is no longer needed.

@jalseth
Copy link
Member Author

jalseth commented Mar 1, 2025

The release failed. Error log below. I'm going to roll back this change.

#0 building with "conftestbuild" instance using docker-container driver
#1 [internal] booting buildkit
#1 pulling image moby/buildkit:buildx-stable-1
#1 pulling image moby/buildkit:buildx-stable-1 2.2s done
#1 creating container buildx_buildkit_conftestbuild0
#1 creating container buildx_buildkit_conftestbuild0 0.3s done
#1 DONE 2.5s
ERROR: invalid tag "openpolicyagent/conftest:": invalid reference format
Reference
Check build summary support
Error: buildx failed with: ERROR: invalid tag "openpolicyagent/conftest:": invalid reference format

@Amamgbu
Copy link
Contributor

Amamgbu commented Mar 3, 2025

I have identified the issue and made a fix to that effect @jalseth

@Amamgbu Amamgbu mentioned this issue Mar 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amamgbu Amamgbu

Labels
docker Pull requests that update Docker code enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@Amamgbu @jalseth