Odyssey FFDC: Connect to PLDM

This commit connects the Odyssey FIFO FFDC dump chipop to PLDM. A user
can execute the following PLDM command to trigger an Odyssey FFDC dump
at a "stable" point in IPL (like in between Hostboot isteps):

pldmtool raw -m 9 -d 0x80 0x3F 0x0D
pldmtool raw -m 10 -d 0x80 0x3F 0x0D  // For HBRT

The command will request all functional Odyssey chips in the system to
return FFDC. The FFDC (attribute data and traces) is then placed in an
error log (one error log per OCMB).

Change-Id: I62805b01e917d9e956ac6fd99d25b77ef6f74549
JIRA: PFHB-254
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/158695
Reviewed-by: Deborah L McLemore <[email protected]>
Reviewed-by: Daniel M Crowell <[email protected]>
Tested-by: Jenkins OP Build CI <[email protected]>
Tested-by: Jenkins Server <[email protected]>
Tested-by: Jenkins Combined Simics CI <[email protected]>
Tested-by: Jenkins OP HW <[email protected]>
Tested-by: Hostboot CI <[email protected]>
Reviewed-by: Ilya Smirnov <[email protected]>

Author: Ilya Smirnov

src/include/usr/pldm/responses/pldm_oem_responders.H

@@ -5,7 +5,7 @@
 /*                                                                        */
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
-/* Contributors Listed Below - COPYRIGHT 2022                             */
+/* Contributors Listed Below - COPYRIGHT 2022,2023                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
 /*                                                                        */
@@ -60,5 +60,18 @@ errlHndl_t handleGetPldmAttrDumpRequest(MCTP::mctp_outbound_msgq_t i_msgQ,
 errlHndl_t handleHtmgtRequest(MCTP::mctp_outbound_msgq_t i_msgQ,
                               const pldm_mctp_message& i_msg);
 
+/**
+ * @brief handleOdyFFDCRequest
+ *
+ *        Handler for intercepting the Odyssey FIFO FFDC request from BMC.
+ *
+ * @param[in] i_msgQ          Handle to the MCTP outbound message queue
+ * @param[in] i_msg           Request message object
+ *
+ * @return always nullptr
+ */
+errlHndl_t handleOdyFFDCRequest(MCTP::mctp_outbound_msgq_t i_msgQ,
+                                const pldm_mctp_message& i_msg);
+
 } // namespace PLDM
 #endif

src/subtree/openbmc/pldm/libpldm/include/libpldm/oem/ibm/libpldm/file_io.h

@@ -26,6 +26,7 @@ enum pldm_fileio_commands {
 	PLDM_NEW_FILE_AVAILABLE_WITH_META_DATA = 0xE,
 	PLDM_FILE_ACK_WITH_META_DATA = 0xF,
 
+    PLDM_GET_ODY_FFDC  = 0xD, // Note overlap with earlier commands
 	PLDM_GET_ATTR_DUMP = 0xE, // Note overlap with earlier commands
 	PLDM_HTMGT_REQUEST = 0xF, // Note overlap with earlier commands
 };

src/usr/pldm/common/common.mk

@@ -52,6 +52,7 @@ EXTRAINCDIR += ${COMMON_ROOTPATH}/src/import/hwpf/fapi2/include/
 EXTRAINCDIR += ${COMMON_ROOTPATH}/src/include/usr/fapi2/
 EXTRAINCDIR += ${COMMON_ROOTPATH}/src/import/chips/p10/common/include/
 EXTRAINCDIR += ${COMMON_ROOTPATH}/src/import/chips/common/utils/imageProcs
+EXTRAINCDIR += ${COMMON_ROOTPATH}/src/import/chips/common/utils/
 EXTRAINCDIR += ${COMMON_ROOTPATH}/src/import/chips/p10/procedures/hwp/ffdc
 EXTRAINCDIR += ${COMMON_ROOTPATH}/src/import/chips/p10/procedures/hwp/sbe
 EXTRAINCDIR += ${COMMON_ROOTPATH}/src/import/chips/p10/procedures/hwp/perv

src/usr/pldm/extended/pldm_responder.C

@@ -119,10 +119,11 @@ const msg_type_handler pldm_fru_data_handlers[] =
 
 const msg_type_handler pldm_oem_handlers[] =
 {
-    { PLDM_GET_ATTR_DUMP, handleGetPldmAttrDumpRequest }
+    { PLDM_GET_ATTR_DUMP, handleGetPldmAttrDumpRequest },
 #ifdef CONFIG_HTMGT
-    ,{ PLDM_HTMGT_REQUEST, handleHtmgtRequest }
+    { PLDM_HTMGT_REQUEST, handleHtmgtRequest },
 #endif
+    { PLDM_GET_ODY_FFDC, handleOdyFFDCRequest }
 };
 
 /*** Top-level table of handler tables ***/

src/usr/pldm/responses/pldm_oem_responders.C

@@ -5,7 +5,7 @@
 /*                                                                        */
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
-/* Contributors Listed Below - COPYRIGHT 2022                             */
+/* Contributors Listed Below - COPYRIGHT 2022,2023                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
 /*                                                                        */
@@ -33,6 +33,7 @@
 #include <pldm/pldm_response.H> // send_cc_only_response
 #include <pldm/pldm_trace.H>    // PLDM_INF
 #include <htmgt/htmgt.H>
+#include <sbeio/sbeioif.H>
 
 namespace PLDM
 {
@@ -111,4 +112,11 @@ errlHndl_t handleHtmgtRequest(const MCTP::mctp_outbound_msgq_t i_msgQ,
     return l_errl;
 }
 
+errlHndl_t handleOdyFFDCRequest(const MCTP::mctp_outbound_msgq_t i_msgQ,
+                                const pldm_mctp_message& i_msg)
+{
+    SBEIO::handleGenFifoSBEFFDCErrlRequest();
+    return nullptr;
+}
+
 } // namespace PLDM