Skip to content

Commit 578a203

Browse files
authored
Merge pull request #427 from debmc/occ
OpTestOCC: Catch exceptions to fail test
2 parents 2b18047 + 132c202 commit 578a203

File tree

1 file changed

+33
-20
lines changed

1 file changed

+33
-20
lines changed

testcases/OpTestOCC.py

+33-20
Original file line numberDiff line numberDiff line change
@@ -77,23 +77,31 @@ def do_occ_reset_fsp(self):
7777
self.assertEqual(int(res[-1]), 0, "occ reset command failed from fsp")
7878

7979
def do_occ_reset(self):
80-
log.debug("OPAL-PRD: OCC Enable")
81-
self.c.run_command(BMC_CONST.OCC_ENABLE)
82-
log.debug("OPAL-PRD: OCC DISABLE")
83-
self.c.run_command(BMC_CONST.OCC_DISABLE)
84-
log.debug("OPAL-PRD: OCC Enable")
85-
self.c.run_command(BMC_CONST.OCC_ENABLE)
86-
log.debug("OPAL-PRD: OCC RESET")
87-
self.c.run_command(BMC_CONST.OCC_RESET)
80+
try:
81+
log.debug("OPAL-PRD: OCC Enable")
82+
self.c.run_command(BMC_CONST.OCC_ENABLE)
83+
log.debug("OPAL-PRD: OCC DISABLE")
84+
self.c.run_command(BMC_CONST.OCC_DISABLE)
85+
log.debug("OPAL-PRD: OCC Enable")
86+
self.c.run_command(BMC_CONST.OCC_ENABLE)
87+
log.debug("OPAL-PRD: OCC RESET")
88+
self.c.run_command(BMC_CONST.OCC_RESET)
89+
except Exception as e:
90+
log.debug("Unexpected problem, Exception={}".format(e))
91+
self.assertTrue(False, "Unexpected problem, Exception={}".format(e))
8892

8993
def clear_occ_rr_count(self):
9094
# Clear the OCC reset reload count
91-
log.debug("OPAL-PRD: occ query reset reload count")
92-
self.c.run_command(BMC_CONST.OCC_QUERY_RESET_COUNTS)
93-
log.debug("OPAL-PRD: occ reset reset/reload count")
94-
self.c.run_command(BMC_CONST.OCC_SET_RESET_RELOAD_COUNT)
95-
log.debug("OPAL-PRD: occ query reset reload count")
96-
self.c.run_command(BMC_CONST.OCC_QUERY_RESET_COUNTS)
95+
try:
96+
log.debug("OPAL-PRD: occ query reset reload count")
97+
self.c.run_command(BMC_CONST.OCC_QUERY_RESET_COUNTS)
98+
log.debug("OPAL-PRD: occ reset reset/reload count")
99+
self.c.run_command(BMC_CONST.OCC_SET_RESET_RELOAD_COUNT)
100+
log.debug("OPAL-PRD: occ query reset reload count")
101+
self.c.run_command(BMC_CONST.OCC_QUERY_RESET_COUNTS)
102+
except Exception as e:
103+
log.debug("Unexpected problem, Exception={}".format(e))
104+
self.assertTrue(False, "Unexpected problem, Exception={}".format(e))
97105

98106
def check_occ_status(self):
99107
'''
@@ -274,12 +282,17 @@ def test_occ_enable_disable_functionality(self):
274282
self.assertNotEqual(self.check_occ_status(), BMC_CONST.FW_FAILED,
275283
"OCC's are not in active state")
276284
for count in range(1,7):
277-
log.debug("OPAL-PRD: OCC Enable")
278-
self.c.run_command(BMC_CONST.OCC_ENABLE)
279-
log.debug("OPAL-PRD: OCC Disable")
280-
self.c.run_command(BMC_CONST.OCC_DISABLE)
281-
log.debug("OPAL-PRD: OCC Enable")
282-
self.c.run_command(BMC_CONST.OCC_ENABLE)
285+
try:
286+
log.debug("OPAL-PRD: OCC Enable")
287+
self.c.run_command(BMC_CONST.OCC_ENABLE)
288+
log.debug("OPAL-PRD: OCC Disable")
289+
self.c.run_command(BMC_CONST.OCC_DISABLE)
290+
log.debug("OPAL-PRD: OCC Enable")
291+
self.c.run_command(BMC_CONST.OCC_ENABLE)
292+
except Exception as e:
293+
log.debug("Unexpected problem, Exception={}".format(e))
294+
self.assertTrue(False, "Unexpected problem, Exception={}".format(e))
295+
283296
tries = 12
284297
for i in range(1, tries):
285298
log.debug("Waiting for OCC Enable\Disable (%d\%d)"%(i,tries))

0 commit comments

Comments
 (0)