Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 8221eec

Browse files
authoredMay 20, 2024··
Update PowerNVDump.py with review comments
1 parent 02376f5 commit 8221eec

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed
 

‎testcases/PowerNVDump.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@ def setup_pwdless_auth(self):
170170
self.c.run_command(
171171
"ssh-keygen -q -t rsa -f %s -P ''" % self.rsa_path)
172172
self.c.run_command("chmod 400 %s" % self.rsa_path)
173-
(self.dump_server_pw, self.rsa_path, self.dump_server_ip))
174173
self.c.run_command("sshpass -p %s ssh-copy-id -o \"StrictHostKeyChecking no\" -i %s %s@%s" %
175174
(self.dump_server_pw, self.rsa_path, self.dump_server_user, self.dump_server_ip))
176175
except CommandFailed:
@@ -295,10 +294,7 @@ def verify_dump_file(self, boot_type=BootType.NORMAL, dump_place="local"):
295294
else:
296295
msg = "Dump directory not created"
297296
raise OpTestError(msg)
298-
if self.dump_server_user != 'root':
299-
#cannot delete with normal user since dump dir is owned by root
300-
pass
301-
else:
297+
if self.dump_server_user == 'root':
302298
self.c.run_command("rm -rf /var/crash/%s; sync" % self.crash_content[0])
303299

304300
def verify_fadump_reg(self):

0 commit comments

Comments
 (0)
Please sign in to comment.