Skip to content

Commit 6790a94

Browse files
mikeystewartsmith
authored andcommitted
hmi: Fix clearing HMER on debug trigger
In the recent patch: eddff9b hmi: Clear unknown debug trigger I rebased the code from an older skiboot before the HMI rework. When I did this, I missed the handled flag. Without this the HMER is not cleared properly and the HMI keeps happening. This properly sets the handled flag and hence clears the HMER bit. Signed-off-by: Michael Neuling <[email protected]> Reviewed-by: Mahesh Salgaonkar <[email protected]> Signed-off-by: Stewart Smith <[email protected]>
1 parent 6449e2a commit 6790a94

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

core/hmi.c

+1
Original file line numberDiff line numberDiff line change
@@ -1259,6 +1259,7 @@ static int handle_hmi_exception(uint64_t hmer, struct OpalHMIEvent *hmi_evt,
12591259
}
12601260
}
12611261
if (hmer & SPR_HMER_TRIG_FIR_HMI) {
1262+
handled |= SPR_HMER_TRIG_FIR_HMI;
12621263
hmer &= ~SPR_HMER_TRIG_FIR_HMI;
12631264

12641265
hmi_print_debug("Clearing unknown debug trigger", hmer);

0 commit comments

Comments
 (0)