feat(httptransport): injected fetcher#330
Conversation
|
prettier applied most changes. |
zcstarr
left a comment
There was a problem hiding this comment.
This is great, looks good to me. The only thing missing here is just a test in HttpTransport.test.js to add a mock injected fetcher and verify it gets called. Then we're golden good to land this. Thanks for the PR. and just ping me when the test case is in
@zcstarr All done 💪 |
|
Let me know when tagged/published and I will make the upgrade to the generator |
|
who can merge? |
|
@BelfordZ hey ping here we need a permissions reset here, CI has expired |
Codecov ReportBase: 99.26% // Head: 99.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
==========================================
+ Coverage 99.26% 99.27% +0.01%
==========================================
Files 11 11
Lines 410 416 +6
Branches 62 65 +3
==========================================
+ Hits 407 413 +6
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thanks for the PR, good stuff! |
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@maurerbot sry for the delay in responding and thanks again for the contrib! Feel free to make open-rpc projects your own, and contribute whereever you'd like! |
No problemo. Just want to relink this related PR: open-rpc/generator#700 |

Adds the ability to inject a customer fetcher
Purpose:
To. be able to inject binded fetchers in cloudflare workers
https://developers.cloudflare.com/workers/platform/bindings/about-service-bindings/
@openrpc/generator will need a version bump for this dep and change the template to accept options: https://github.com/open-rpc/generator/blob/40f6a9c7f0b264f6498b32bb4648e3b246e3c093/src/components/client.ts#L50