-
-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Description
Currently, the minimum free disk env variable is parsed as uint64:
Lines 71 to 78 in 51ed9ca
// Validates the provided minimum free disk int is parsable as a uint64 | |
// | |
// TODO - should dynamically check file system bit size after compilation. | |
// 64 bit wide words should be fine for almost all use cases for now. | |
minFreeDiskUint64, err := strconv.ParseUint(minFreeDisk, 10, 64) | |
if err != nil { | |
sugarLogger.Fatalf(": %s", err.Error()) | |
} |
This is mostly fine since I'd imagine we're only going to deploy this to 64 bit systems.
A stretch goal / nice to have someday would be to make this dynamic for the system that is being compiled to. I think this would be a simple check against bits.UintSize
(which should be set at compile time).
The tricky part will be cross building images on different machines with the right bit lengths.
But again, I anticipate only really needing 64 bit systems, so this is a stretch goal.
Metadata
Metadata
Assignees
Labels
No labels