[chore] add a few anonymous struct fields to disallow unkeyed initialization (#38509)

See
#37889

Author: atoulme

connector/exceptionsconnector/config.go

@@ -31,6 +31,8 @@ type Config struct {
 	Dimensions []Dimension `mapstructure:"dimensions"`
 	// Exemplars defines the configuration for exemplars.
 	Exemplars Exemplars `mapstructure:"exemplars"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 var _ xconfmap.Validator = (*Config)(nil)

connector/failoverconnector/config.go

@@ -33,6 +33,8 @@ type Config struct {
 	// MaxRetry is the maximum retries per level, once this limit is hit for a level, even if the next pipeline level fails,
 	// it will not try to recover the level that exceeded the maximum retries
 	MaxRetries int `mapstructure:"max_retries"` // **Deprecated**
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 // Validate needs to ensure RetryInterval > # elements in PriorityList * RetryGap

connector/grafanacloudconnector/config.go

@@ -16,6 +16,8 @@ type Config struct {
 	// a unique `grafana.host.id` value. In most cases, this should be [ "host.id" ]
 	HostIdentifiers      []string      `mapstructure:"host_identifiers"`
 	MetricsFlushInterval time.Duration `mapstructure:"metrics_flush_interval"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 var _ xconfmap.Validator = (*Config)(nil)

connector/routingconnector/config.go

@@ -39,6 +39,8 @@ type Config struct {
 	// Table contains the routing table for this processor.
 	// Required.
 	Table []RoutingTableItem `mapstructure:"table"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 // Validate checks if the processor configuration is valid.
@@ -97,4 +99,6 @@ type RoutingTableItem struct {
 	// The routing processor will fail upon the first failure from these pipelines.
 	// Optional.
 	Pipelines []pipeline.ID `mapstructure:"pipelines"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }

connector/signaltometricsconnector/config/config.go

@@ -42,6 +42,8 @@ type Config struct {
 	Spans      []MetricInfo `mapstructure:"spans"`
 	Datapoints []MetricInfo `mapstructure:"datapoints"`
 	Logs       []MetricInfo `mapstructure:"logs"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 func (c *Config) Validate() error {
@@ -158,6 +160,8 @@ type MetricInfo struct {
 	Histogram            *Histogram            `mapstructure:"histogram"`
 	ExponentialHistogram *ExponentialHistogram `mapstructure:"exponential_histogram"`
 	Sum                  *Sum                  `mapstructure:"sum"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 func (mi *MetricInfo) ensureDefaults() {

connector/spanmetricsconnector/config.go

@@ -29,6 +29,8 @@ var defaultDeltaTimestampCacheSize = 1000
 type Dimension struct {
 	Name    string  `mapstructure:"name"`
 	Default *string `mapstructure:"default"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 // Config defines the configuration options for spanmetricsconnector.
@@ -91,6 +93,8 @@ type HistogramConfig struct {
 	Unit        metrics.Unit                `mapstructure:"unit"`
 	Exponential *ExponentialHistogramConfig `mapstructure:"exponential"`
 	Explicit    *ExplicitHistogramConfig    `mapstructure:"explicit"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 type ExemplarsConfig struct {

connector/spanmetricsconnector/connector_test.go

@@ -464,19 +464,19 @@ func newConnectorImp(defaultNullValue *string, histogramConfig func() HistogramC
 		ResourceMetricsKeyAttributes: resourceMetricsKeyAttributes,
 		Dimensions: []Dimension{
 			// Set nil defaults to force a lookup for the attribute in the span.
-			{stringAttrName, nil},
-			{intAttrName, nil},
-			{doubleAttrName, nil},
-			{boolAttrName, nil},
-			{mapAttrName, nil},
-			{arrayAttrName, nil},
-			{nullAttrName, defaultNullValue},
+			{Name: stringAttrName, Default: nil},
+			{Name: intAttrName, Default: nil},
+			{Name: doubleAttrName, Default: nil},
+			{Name: boolAttrName, Default: nil},
+			{Name: mapAttrName, Default: nil},
+			{Name: arrayAttrName, Default: nil},
+			{Name: nullAttrName, Default: defaultNullValue},
 			// Add a default value for an attribute that doesn't exist in a span
-			{notInSpanAttrName0, stringp("defaultNotInSpanAttrVal")},
+			{Name: notInSpanAttrName0, Default: stringp("defaultNotInSpanAttrVal")},
 			// Leave the default value unset to test that this dimension should not be added to the metric.
-			{notInSpanAttrName1, nil},
+			{Name: notInSpanAttrName1, Default: nil},
 			// Add a resource attribute to test "process" attributes like IP, host, region, cluster, etc.
-			{regionResourceAttrName, nil},
+			{Name: regionResourceAttrName, Default: nil},
 		},
 		Events:               eventsConfig(),
 		MetricsExpiration:    expiration,

connector/sumconnector/config.go

@@ -22,6 +22,8 @@ type Config struct {
 	Metrics    map[string]MetricInfo `mapstructure:"metrics"`
 	DataPoints map[string]MetricInfo `mapstructure:"datapoints"`
 	Logs       map[string]MetricInfo `mapstructure:"logs"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 // MetricInfo for a data type
@@ -30,11 +32,15 @@ type MetricInfo struct {
 	Conditions      []string          `mapstructure:"conditions"`
 	Attributes      []AttributeConfig `mapstructure:"attributes"`
 	SourceAttribute string            `mapstructure:"source_attribute"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 type AttributeConfig struct {
 	Key          string `mapstructure:"key"`
 	DefaultValue any    `mapstructure:"default_value"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 func (c *Config) Validate() (combinedErrors error) {

receiver/azureblobreceiver/config.go

@@ -38,21 +38,29 @@ type Config struct {
 	Logs LogsConfig `mapstructure:"logs"`
 	// Traces related configurations
 	Traces TracesConfig `mapstructure:"traces"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 type EventHubConfig struct {
 	// Azure Event Hub endpoint triggering on the `Blob Create` event
 	EndPoint string `mapstructure:"endpoint"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 type LogsConfig struct {
 	// Name of the blob container with the logs (default = "logs")
 	ContainerName string `mapstructure:"container_name"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 type TracesConfig struct {
 	// Name of the blob container with the traces (default = "traces")
 	ContainerName string `mapstructure:"container_name"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 type ServicePrincipalConfig struct {
@@ -62,6 +70,8 @@ type ServicePrincipalConfig struct {
 	ClientID string `mapstructure:"client_id"`
 	// Client secret, used with Service Principal authentication
 	ClientSecret configopaque.String `mapstructure:"client_secret"`
+	// prevent unkeyed literal initialization
+	_ struct{}
 }
 
 type AuthType string