Skip to content

Commit 6e64a27

Browse files
authored
[chore] Move exporter/internal to exporterhelper/internal when possible (#12683)
Signed-off-by: Bogdan Drutu <[email protected]>
1 parent 6aad9d1 commit 6e64a27

File tree

12 files changed

+39
-32
lines changed

12 files changed

+39
-32
lines changed
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
// Copyright The OpenTelemetry Authors
2+
// SPDX-License-Identifier: Apache-2.0
3+
4+
package experr // import "go.opentelemetry.io/collector/exporter/exporterhelper/internal/experr"
5+
6+
import (
7+
"errors"
8+
)
9+
10+
type shutdownErr struct {
11+
err error
12+
}
13+
14+
func NewShutdownErr(err error) error {
15+
return shutdownErr{err: err}
16+
}
17+
18+
func (s shutdownErr) Error() string {
19+
return "interrupted due to shutdown: " + s.err.Error()
20+
}
21+
22+
func (s shutdownErr) Unwrap() error {
23+
return s.err
24+
}
25+
26+
func IsShutdownErr(err error) bool {
27+
var sdErr shutdownErr
28+
return errors.As(err, &sdErr)
29+
}

exporter/exporterhelper/internal/queue_sender_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ import (
2323
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/queuebatch"
2424
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/request"
2525
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/requesttest"
26+
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/storagetest"
2627
"go.opentelemetry.io/collector/exporter/exporterqueue"
27-
"go.opentelemetry.io/collector/exporter/internal/storagetest"
2828
)
2929

3030
type fakeEncoding struct {

exporter/exporterhelper/internal/queuebatch/persistent_queue.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import (
1515

1616
"go.opentelemetry.io/collector/component"
1717
"go.opentelemetry.io/collector/exporter"
18+
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/experr"
1819
"go.opentelemetry.io/collector/exporter/exporterqueue"
19-
"go.opentelemetry.io/collector/exporter/internal/experr"
2020
"go.opentelemetry.io/collector/extension/xextension/storage"
2121
"go.opentelemetry.io/collector/pipeline"
2222
)

exporter/exporterhelper/internal/queuebatch/persistent_queue_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ import (
2020
"github.com/stretchr/testify/require"
2121

2222
"go.opentelemetry.io/collector/component"
23+
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/experr"
24+
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/storagetest"
2325
"go.opentelemetry.io/collector/exporter/exportertest"
24-
"go.opentelemetry.io/collector/exporter/internal/experr"
25-
"go.opentelemetry.io/collector/exporter/internal/storagetest"
2626
"go.opentelemetry.io/collector/extension/extensiontest"
2727
"go.opentelemetry.io/collector/extension/xextension/storage"
2828
"go.opentelemetry.io/collector/pipeline"

exporter/exporterhelper/internal/retry_sender.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ import (
1818
"go.opentelemetry.io/collector/config/configretry"
1919
"go.opentelemetry.io/collector/consumer/consumererror"
2020
"go.opentelemetry.io/collector/exporter"
21+
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/experr"
2122
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/request"
22-
"go.opentelemetry.io/collector/exporter/internal/experr"
2323
)
2424

2525
// TODO: Clean this by forcing all exporters to return an internal error type that always include the information about retries.

exporter/internal/storagetest/mock_storage.go renamed to exporter/exporterhelper/internal/storagetest/mock_storage.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright The OpenTelemetry Authors
22
// SPDX-License-Identifier: Apache-2.0
33

4-
package storagetest // import "go.opentelemetry.io/collector/exporter/internal/storagetest"
4+
package storagetest // import "go.opentelemetry.io/collector/exporter/exporterhelper/internal/storagetest"
55

66
import (
77
"context"

exporter/exporterhelper/logs_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ import (
3131
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/metadatatest"
3232
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/oteltest"
3333
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/requesttest"
34+
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/storagetest"
3435
"go.opentelemetry.io/collector/exporter/exportertest"
35-
"go.opentelemetry.io/collector/exporter/internal/storagetest"
3636
"go.opentelemetry.io/collector/pdata/plog"
3737
"go.opentelemetry.io/collector/pdata/testdata"
3838
)

exporter/exporterhelper/metrics_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ import (
3131
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/metadatatest"
3232
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/oteltest"
3333
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/requesttest"
34+
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/storagetest"
3435
"go.opentelemetry.io/collector/exporter/exportertest"
35-
"go.opentelemetry.io/collector/exporter/internal/storagetest"
3636
"go.opentelemetry.io/collector/pdata/pmetric"
3737
"go.opentelemetry.io/collector/pdata/testdata"
3838
)

exporter/exporterhelper/traces_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ import (
3131
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/metadatatest"
3232
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/oteltest"
3333
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/requesttest"
34+
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/storagetest"
3435
"go.opentelemetry.io/collector/exporter/exportertest"
35-
"go.opentelemetry.io/collector/exporter/internal/storagetest"
3636
"go.opentelemetry.io/collector/pdata/ptrace"
3737
"go.opentelemetry.io/collector/pdata/testdata"
3838
)

exporter/exporterhelper/xexporterhelper/profiles_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ import (
3131
"go.opentelemetry.io/collector/exporter/exporterhelper/internal"
3232
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/oteltest"
3333
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/requesttest"
34+
"go.opentelemetry.io/collector/exporter/exporterhelper/internal/storagetest"
3435
"go.opentelemetry.io/collector/exporter/exportertest"
35-
"go.opentelemetry.io/collector/exporter/internal/storagetest"
3636
"go.opentelemetry.io/collector/exporter/xexporter"
3737
"go.opentelemetry.io/collector/pdata/pprofile"
3838
"go.opentelemetry.io/collector/pdata/testdata"

exporter/internal/experr/err.go

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,33 +4,11 @@
44
package experr // import "go.opentelemetry.io/collector/exporter/internal/experr"
55

66
import (
7-
"errors"
87
"fmt"
98

109
"go.opentelemetry.io/collector/component"
1110
)
1211

13-
type shutdownErr struct {
14-
err error
15-
}
16-
17-
func NewShutdownErr(err error) error {
18-
return shutdownErr{err: err}
19-
}
20-
21-
func (s shutdownErr) Error() string {
22-
return "interrupted due to shutdown: " + s.err.Error()
23-
}
24-
25-
func (s shutdownErr) Unwrap() error {
26-
return s.err
27-
}
28-
29-
func IsShutdownErr(err error) bool {
30-
var sdErr shutdownErr
31-
return errors.As(err, &sdErr)
32-
}
33-
3412
func ErrIDMismatch(id component.ID, typ component.Type) error {
3513
return fmt.Errorf("component type mismatch: component ID %q does not have type %q", id, typ)
3614
}

0 commit comments

Comments
 (0)