Skip to content

Commit 76af795

Browse files
authored
[chore] move api-diff pipeline to ubuntu runner (#12549)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Move the api-diff workflow to the standard `ubuntu-latest` runner and adjust the OS dependent call to mktemp so that it works for both linux and macos. <!-- Issue number if applicable --> #### Link to tracking issue Fixes #7444 #### Testing Tested on my fork: https://github.com/mowies/opentelemetry-collector/actions/runs/13941800348/job/39019991437 Also tested this locally on MacOS. <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Moritz Wiesinger <[email protected]>
1 parent 29d233f commit 76af795

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/api-compatibility.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ permissions: read-all
1414

1515
jobs:
1616
Check-Compatibility:
17-
runs-on: macos-latest
17+
runs-on: ubuntu-latest
1818
env:
1919
BASE_REF: ${{ github.base_ref }}
2020
HEAD_REF: ${{ github.head_ref }}

internal/buildscripts/gen-apidiff.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ fi
4545
set -ex
4646

4747
# Create temp dir for generated files.
48-
tmp_dir=$(mktemp -d -t apidiff)
48+
# Source: https://unix.stackexchange.com/a/84980
49+
tmp_dir=$(mktemp -d 2>/dev/null || mktemp -d -t 'apidiff')
4950
clean_up() {
5051
ARG=$?
5152
if [ $dry_run = true ]; then

0 commit comments

Comments
 (0)