Skip to content

Commit bf1a374

Browse files
authored
[mdatagen] fix missing resource attributes import in metrics template (#12456)
#### Description Re-adds the missing import for the `ResourceAttributes` for metrics generation. This impacts receivers that emit resource attributes. Filter is still within the template code for resource attributes, but not imported. #### Link to tracking issue Fixes #12455
1 parent 6de29ce commit bf1a374

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

.chloggen/mdatagen-fix.yaml

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
7+
component: mdatagen
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Adds back missing import for filter when emitting resource attributes
11+
12+
# One or more tracking issues or pull requests related to the change
13+
issues: [12455]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# Optional: The change log or logs in which this entry should be included.
21+
# e.g. '[user]' or '[user, api]'
22+
# Include 'user' if the change is relevant to end users.
23+
# Include 'api' if there is a change to a library API.
24+
# Default: '[user]'
25+
change_logs: []

cmd/mdatagen/internal/templates/metrics.go.tmpl

+3
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ import (
1818
{{- if .SemConvVersion }}
1919
conventions "go.opentelemetry.io/collector/semconv/v{{ .SemConvVersion }}"
2020
{{- end }}
21+
{{ if .ResourceAttributes -}}
22+
"go.opentelemetry.io/collector/filter"
23+
{{- end }}
2124
)
2225

2326
{{ range $name, $info := .Attributes }}

0 commit comments

Comments
 (0)