-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump minimum supported go version to 1.23 #12370
Conversation
With the release of 1.24, we need to bump the tested versions. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we could try to do 1.23
instead of 1.23.0
, but I think we'll have to do 1.23.0
eventually, so I am not sure it is worth it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also notes in the builder readme and in CONTRIBUTING.md that need to be updated.
Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12370 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 466 466
Lines 25612 25612
=======================================
Hits 23434 23434
Misses 1774 1774
Partials 404 404 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <[email protected]>
@evan-bradley i updated the docs and removed the bits that only seemed relevant before 1.23 was the minimum, ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc changes LGTM.
e4b9425
With the release of 1.24, we need to bump the tested versions.