Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minimum supported go version to 1.23 #12370

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

codeboten
Copy link
Contributor

With the release of 1.24, we need to bump the tested versions.

With the release of 1.24, we need to bump the tested versions.

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten requested a review from a team as a code owner February 12, 2025 13:59
@codeboten codeboten requested a review from dmitryax February 12, 2025 13:59
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could try to do 1.23 instead of 1.23.0, but I think we'll have to do 1.23.0 eventually, so I am not sure it is worth it

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also notes in the builder readme and in CONTRIBUTING.md that need to be updated.

Signed-off-by: Alex Boten <[email protected]>
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (d668e74) to head (4ed30ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12370   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         466      466           
  Lines       25612    25612           
=======================================
  Hits        23434    23434           
  Misses       1774     1774           
  Partials      404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten enabled auto-merge February 12, 2025 14:35
@codeboten codeboten disabled auto-merge February 12, 2025 14:36
@codeboten
Copy link
Contributor Author

There are also notes in the builder readme and in CONTRIBUTING.md that need to be updated.

@evan-bradley i updated the docs and removed the bits that only seemed relevant before 1.23 was the minimum, ptal

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes LGTM.

@codeboten codeboten added this pull request to the merge queue Feb 12, 2025
Merged via the queue into open-telemetry:main with commit e4b9425 Feb 12, 2025
54 of 55 checks passed
@codeboten codeboten deleted the codeboten/1.24 branch February 12, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing for Go 1.24, drop testing for Go 1.22
5 participants