-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver] Mark module as stable #12560
Conversation
cc @open-telemetry/collector-approvers |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12560 +/- ##
=======================================
Coverage 92.21% 92.21%
=======================================
Files 469 469
Lines 25368 25368
=======================================
Hits 23392 23392
Misses 1568 1568
Partials 408 408 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I intend to merge this next Wednesday EU morning if I get enough approvals by then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OOO, but please check doc.go
and all comments to the funcs/contracts. I remember some being about only one instance, etc.
I looked through the receiver package and didn't see anything nefarious. I also grepped the repository for "instance", but nothing popped up. No TODO showed up either. |
I could not find anything specific to instances in the docs, but I did open this small PR to move error handling documentation to the consumererror package: #12610 (Edit: merged) |
Description
Marks receiver as 1.0. I believe we can do this since this is basically extension+consumer.
receiverhelper
is not ready yetLink to tracking issue
Fixes #12513