Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver] Mark module as stable #12560

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Mar 5, 2025

Description

Marks receiver as 1.0. I believe we can do this since this is basically extension+consumer. receiverhelper is not ready yet

Link to tracking issue

Fixes #12513

@mx-psi mx-psi requested a review from a team as a code owner March 5, 2025 10:22
@mx-psi mx-psi requested a review from dmitryax March 5, 2025 10:22
@mx-psi
Copy link
Member Author

mx-psi commented Mar 5, 2025

cc @open-telemetry/collector-approvers

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (7ee8a2b) to head (2fbc1d7).
Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12560   +/-   ##
=======================================
  Coverage   92.21%   92.21%           
=======================================
  Files         469      469           
  Lines       25368    25368           
=======================================
  Hits        23392    23392           
  Misses       1568     1568           
  Partials      408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi
Copy link
Member Author

mx-psi commented Mar 5, 2025

I intend to merge this next Wednesday EU morning if I get enough approvals by then

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OOO, but please check doc.go and all comments to the funcs/contracts. I remember some being about only one instance, etc.

@atoulme
Copy link
Contributor

atoulme commented Mar 7, 2025

I am OOO, but please check doc.go and all comments to the funcs/contracts. I remember some being about only one instance, etc.

I looked through the receiver package and didn't see anything nefarious. I also grepped the repository for "instance", but nothing popped up. No TODO showed up either.

@mx-psi
Copy link
Member Author

mx-psi commented Mar 11, 2025

I could not find anything specific to instances in the docs, but I did open this small PR to move error handling documentation to the consumererror package: #12610 (Edit: merged)

@mx-psi mx-psi requested a review from bogdandrutu March 12, 2025 11:55
@mx-psi mx-psi added this pull request to the merge queue Mar 14, 2025
Merged via the queue into open-telemetry:main with commit de3b40f Mar 14, 2025
55 checks passed
@mx-psi mx-psi deleted the mx-psi/receiver-1.0 branch March 14, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize module receiver
6 participants