[receiverhelper] Split receiverhelper into a separate module #12512
Conversation
mx-psi
force-pushed
the
mx-psi/split-the-helpers
branch
from
6f7b1c4 to
40e1c35
Compare
mx-psi
force-pushed
the
mx-psi/split-the-helpers
branch
from
40e1c35 to
71b46c7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12512 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 469 469
Lines 25327 25327
=======================================
Hits 23351 23351
Misses 1568 1568
Partials 408 408 ☔ View full report in Codecov by Sentry. |
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.2 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| go.opentelemetry.io/auto/sdk v1.1.0 // indirect | ||
| github.com/rogpeppe/go-internal v1.13.1 // indirect |
There was a problem hiding this comment.
this seems like a weird change
There was a problem hiding this comment.
There are a lot of modules on main that have this indirect dependency (e.g. pdata, connector, confignet, configtelemetry...), see for example
opentelemetry-collector/pdata/go.mod
Line 21 in 909a8bb
I have not been able to figure out why we have this indirect dependency, but I think it's not because of a mistake, it's just what go mod tidy spews out
Pull Request is not mergeable
d1f0805
| go.opentelemetry.io/collector/component/componenttest v0.120.0 | ||
| go.opentelemetry.io/collector/pipeline v0.121.0 | ||
| go.opentelemetry.io/collector/receiver v0.120.0 |
There was a problem hiding this comment.
Versions are incorrect. We probably need something like check-module-version in core collector to catch this
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Split processorhelper into a separate module. Similar to #12512 in motivation and shape <!-- Issue number if applicable --> #### Link to tracking issue Fixes #12678
Description
Splits
receiverhelperinto a separate module.Link to tracking issue
Fixes #12514