Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove unneeded goreleaser hooks #875

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 13, 2025

This PR fixes the first finding of the GoReleaser check workflow in the collector-core repo.
It removes unneeded build hooks from goreleaser configs that failed when running in the collector-core repo.
After looking into it, I found that they are not actually needed.

Fixes open-telemetry/opentelemetry-collector#12618
Fixes open-telemetry/opentelemetry-collector#12619
Fixes open-telemetry/opentelemetry-collector#12623

mowies added 4 commits March 13, 2025 09:06
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies changed the title [chore] test builder goreleaser changes [chore] remove unneeded goreleaser hooks Mar 13, 2025
@mowies mowies marked this pull request as ready for review March 13, 2025 08:47
@mowies mowies requested a review from a team as a code owner March 13, 2025 08:47
@mowies mowies requested a review from jackgopack4 March 13, 2025 08:47
@mx-psi
Copy link
Member

mx-psi commented Mar 13, 2025

This has been carried over since the first iteration observatorium/opentelemetry-collector-builder/pull/5 I agree it does not seem necessary

@mx-psi mx-psi added this pull request to the merge queue Mar 13, 2025
Merged via the queue into open-telemetry:main with commit 15c57e4 Mar 13, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCB snapshot workflow failed OCB snapshot workflow failed OCB snapshot workflow failed
2 participants