Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated func types from exporterhelper #12686

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested review from mx-psi, dmathieu, a team and dmitryax as code owners March 20, 2025 19:01
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (51a4786) to head (cf8224c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12686   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         482      482           
  Lines       26377    26377           
=======================================
  Hits        24154    24154           
  Misses       1762     1762           
  Partials      461      461           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the changelog

@bogdandrutu bogdandrutu force-pushed the rm-deprecated-helper branch from fca3096 to 23bd83a Compare March 20, 2025 20:01
@bogdandrutu bogdandrutu force-pushed the rm-deprecated-helper branch from 23bd83a to cf8224c Compare March 20, 2025 20:01
@bogdandrutu
Copy link
Member Author

LGTM modulo the changelog

If only I would have pushed the changes from my branch :)

@bogdandrutu bogdandrutu enabled auto-merge March 20, 2025 20:02
@bogdandrutu bogdandrutu added this pull request to the merge queue Mar 20, 2025
Merged via the queue into open-telemetry:main with commit 57f059b Mar 20, 2025
55 of 56 checks passed
@bogdandrutu bogdandrutu deleted the rm-deprecated-helper branch March 20, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants