Enable .NET analyzers

Enable .NET analyzers and address recommendations to avoid redundant work, formatted strings, incorrect use of `ArgumentNullException` and avoiding an instance method that does not access state.

Author: martincostello

src/accounting/Consumer.cs

@@ -39,12 +39,12 @@ public Consumer(ILogger<Consumer> logger)
         _logger = logger;
 
         var servers = Environment.GetEnvironmentVariable("KAFKA_ADDR")
-            ?? throw new ArgumentNullException("KAFKA_ADDR");
+            ?? throw new InvalidOperationException("The KAFKA_ADDR environment variable is not set.");
 
         _consumer = BuildConsumer(servers);
         _consumer.Subscribe(TopicName);
 
-        _logger.LogInformation($"Connecting to Kafka: {servers}");
+        _logger.LogInformation("Connecting to Kafka: {servers}", servers);
         _dbContext = Environment.GetEnvironmentVariable("DB_CONNECTION_STRING") == null ? null : new DBContext();
     }
 
@@ -64,7 +64,7 @@ public void StartListening()
                 }
                 catch (ConsumeException e)
                 {
-                    _logger.LogError(e, "Consume error: {0}", e.Error.Reason);
+                    _logger.LogError(e, "Consume error: {reason}", e.Error.Reason);
                 }
             }
         }
@@ -130,7 +130,7 @@ private void ProcessMessage(Message<string, byte[]> message)
         }
     }
 
-    private IConsumer<string, byte[]> BuildConsumer(string servers)
+    private static IConsumer<string, byte[]> BuildConsumer(string servers)
     {
         var conf = new ConsumerConfig
         {

src/accounting/Directory.Build.props

@@ -6,6 +6,7 @@
     </PropertyGroup>
 
     <PropertyGroup Condition="'$(Configuration)'=='Release'">
+        <AnalysisMode>Minimum</AnalysisMode>
         <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 </Project>

src/cart/Directory.Build.props

@@ -6,6 +6,7 @@
     </PropertyGroup>
 
     <PropertyGroup Condition="'$(Configuration)'=='Release'">
+        <AnalysisMode>Minimum</AnalysisMode>
         <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 </Project>

src/cart/src/cartstore/ValkeyCartStore.cs

@@ -86,7 +86,11 @@ private void EnsureRedisConnected()
                 return;
             }
 
-            _logger.LogDebug("Connecting to Redis: {_connectionString}", _connectionString);
+            if (_logger.IsEnabled(LogLevel.Debug))
+            {
+                _logger.LogDebug("Connecting to Redis: {_connectionString}", _connectionString);
+            }
+
             _redis = ConnectionMultiplexer.Connect(_redisConnectionOptions);
 
             if (_redis == null || !_redis.IsConnected)
@@ -103,7 +107,11 @@ private void EnsureRedisConnected()
             _logger.LogDebug("Performing small test");
             cache.StringSet("cart", "OK" );
             object res = cache.StringGet("cart");
-            _logger.LogDebug("Small test result: {res}", res);
+
+            if (_logger.IsEnabled(LogLevel.Debug))
+            {
+                _logger.LogDebug("Small test result: {res}", res);
+            }
 
             _redis.InternalError += (_, e) => { Console.WriteLine(e.Exception); };
             _redis.ConnectionRestored += (_, _) =>
@@ -124,7 +132,11 @@ private void EnsureRedisConnected()
     public async Task AddItemAsync(string userId, string productId, int quantity)
     {
         var stopwatch = Stopwatch.StartNew();
-        _logger.LogInformation($"AddItemAsync called with userId={userId}, productId={productId}, quantity={quantity}");
+
+        if (_logger.IsEnabled(LogLevel.Information))
+        {
+            _logger.LogInformation("AddItemAsync called with userId={userId}, productId={productId}, quantity={quantity}", userId, productId, quantity);
+        }
 
         try
         {
@@ -173,8 +185,10 @@ public async Task AddItemAsync(string userId, string productId, int quantity)
 
     public async Task EmptyCartAsync(string userId)
     {
-        _logger.LogInformation($"EmptyCartAsync called with userId={userId}");
-
+        if (_logger.IsEnabled(LogLevel.Information))
+        {
+            _logger.LogInformation("EmptyCartAsync called with userId={userId}", userId);
+        }
         try
         {
             EnsureRedisConnected();
@@ -193,7 +207,11 @@ public async Task EmptyCartAsync(string userId)
     public async Task<Oteldemo.Cart> GetCartAsync(string userId)
     {
         var stopwatch = Stopwatch.StartNew();
-        _logger.LogInformation($"GetCartAsync called with userId={userId}");
+
+        if (_logger.IsEnabled(LogLevel.Information))
+        {
+            _logger.LogInformation("GetCartAsync called with userId={userId}", userId);
+        }
 
         try
         {