Skip to content

Commit 12de48e

Browse files
committed
script
1 parent 15c73d6 commit 12de48e

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

.github/scripts/check-package-names.sh

+3-7
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22

33
# shellcheck disable=SC2001
44

5-
# find instrumentation -type d -name "*-common*"
6-
7-
# TODO javaagent modules?
8-
#for file in $(find instrumentation/aws-sdk -name "*.java" | grep library/src/main/java | sed 's#/[^/]*$##' | sort -u); do
9-
for dir in $(cat out); do
5+
for dir in $(find instrumentation -name "*.java" | grep library/src/main/java | sed 's#/[^/]*$##' | sort -u); do
106

117
module_name=$(echo "$dir" | sed 's#.*/\([^/]*\)/library/src/main/java/.*#\1#')
128

@@ -39,7 +35,7 @@ for dir in $(cat out); do
3935
# - netty-common
4036
if [[ ! "$module_name" =~ [0-9]$ && "$module_name" != "lettuce-common" && "$module_name" != "netty-common" ]]; then
4137
echo "module name doesn't have a base version: $dir"
42-
# exit 1
38+
exit 1
4339
fi
4440

4541
simple_module_name=$(echo "$module_name" | sed 's/-[0-9.]*$//' | sed 's/-//g')
@@ -59,7 +55,7 @@ for dir in $(cat out); do
5955

6056
if [[ "$package_name_normalized" != "$expected_package_name_normalized"* ]]; then
6157
echo "ERROR: $dir"
62-
# exit 1
58+
exit 1
6359
fi
6460

6561
done

.github/workflows/build-common.yml

+7
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,13 @@ jobs:
163163

164164
- run: .github/scripts/check-latest-dep-test-overrides.sh
165165

166+
check-package-names:
167+
runs-on: ubuntu-latest
168+
steps:
169+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
170+
171+
- run: .github/scripts/check-package-names.sh
172+
166173
build:
167174
runs-on: ubuntu-latest
168175
steps:

0 commit comments

Comments
 (0)