Skip to content

Commit 1a506cb

Browse files
authored
Document (and remove some) upper version test limits (#12945)
1 parent e5a9d1c commit 1a506cb

File tree

63 files changed

+313
-360
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+313
-360
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
#!/bin/bash -e
2+
3+
# all missing version coverage should be documented in supported-libraries.md
4+
5+
if grep -r --include build.gradle.kts latestDepTestLibrary instrumentation \
6+
| grep -v :+\" \
7+
| grep -v "// see .* module" \
8+
| grep -v "// see test suite below" \
9+
| grep -v "// no longer applicable" \
10+
| grep -v "// related dependency" \
11+
| grep -v "// native on-by-default instrumentation after this version" \
12+
| grep -v "// documented limitation" \
13+
| grep -v "instrumentation/jaxrs-client/jaxrs-client-2.0-testing/build.gradle.kts"; then
14+
15+
echo
16+
echo "Found an undocumented latestDepTestLibrary (see above)."
17+
echo
18+
echo "See .gith/scripts/check-latest-dep-test-overrides.sh in this repository"
19+
echo "and add one of the required comments."
20+
exit 1
21+
fi

.github/scripts/find-instrumentation-with-upper-version-limits.sh

-6
This file was deleted.

.github/workflows/build-common.yml

+7
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,13 @@ jobs:
119119
exit 1
120120
fi
121121
122+
check-latest-dep-test-overrides:
123+
runs-on: ubuntu-latest
124+
steps:
125+
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
126+
127+
- run: .github/scripts/check-latest-dep-test-overrides.sh
128+
122129
build:
123130
runs-on: ubuntu-latest
124131
steps:

docs/supported-libraries.md

+13-12
Large diffs are not rendered by default.

instrumentation/apache-shenyu-2.4/javaagent/build.gradle.kts

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ muzzle {
1212
}
1313

1414
dependencies {
15-
compileOnly("org.apache.shenyu:shenyu-web:2.4.0")
15+
library("org.apache.shenyu:shenyu-web:2.4.0")
1616
compileOnly("com.google.auto.value:auto-value-annotations")
1717
annotationProcessor("com.google.auto.value:auto-value")
1818

@@ -27,7 +27,7 @@ dependencies {
2727
}
2828

2929
// the latest version of apache shenyu uses spring-boot 2.7
30-
latestDepTestLibrary("org.springframework.boot:spring-boot-starter-test:2.7.+")
30+
latestDepTestLibrary("org.springframework.boot:spring-boot-starter-test:2.7.+") // related dependency
3131

3232
testInstrumentation(project(":instrumentation:netty:netty-4.1:javaagent"))
3333
}

instrumentation/aws-sdk/aws-sdk-1.11/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ dependencies {
6363
testImplementation("javax.xml.bind:jaxb-api:2.3.1")
6464

6565
// last version that does not use json protocol
66-
latestDepTestLibrary("com.amazonaws:aws-java-sdk-sqs:1.12.583")
66+
latestDepTestLibrary("com.amazonaws:aws-java-sdk-sqs:1.12.583") // documented limitation
6767
}
6868

6969
testing {

instrumentation/aws-sdk/aws-sdk-1.11/library-autoconfigure/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ dependencies {
2020
testLibrary("com.amazonaws:aws-java-sdk-sqs:1.11.106")
2121

2222
// last version that does not use json protocol
23-
latestDepTestLibrary("com.amazonaws:aws-java-sdk-sqs:1.12.583")
23+
latestDepTestLibrary("com.amazonaws:aws-java-sdk-sqs:1.12.583") // documented limitation
2424
}
2525

2626
tasks {

instrumentation/aws-sdk/aws-sdk-1.11/library/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ dependencies {
1919
testLibrary("com.amazonaws:aws-java-sdk-sns:1.11.106")
2020

2121
// last version that does not use json protocol
22-
latestDepTestLibrary("com.amazonaws:aws-java-sdk-sqs:1.12.583")
22+
latestDepTestLibrary("com.amazonaws:aws-java-sdk-sqs:1.12.583") // documented limitation
2323
}
2424

2525
if (!(findProperty("testLatestDeps") as Boolean)) {

instrumentation/couchbase/couchbase-2.0/javaagent/build.gradle.kts

+2-3
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,8 @@ dependencies {
2626

2727
testImplementation(project(":instrumentation:couchbase:couchbase-common:testing"))
2828

29-
// later versions are tested with couchbase-2.6 instrumentation
30-
latestDepTestLibrary("org.springframework.data:spring-data-couchbase:2.+")
31-
latestDepTestLibrary("com.couchbase.client:java-client:2.5.+")
29+
latestDepTestLibrary("org.springframework.data:spring-data-couchbase:2.+") // see couchbase-2.6 module
30+
latestDepTestLibrary("com.couchbase.client:java-client:2.5.+") // see couchbase-2.6 module
3231
}
3332

3433
tasks {

instrumentation/couchbase/couchbase-2.6/javaagent/build.gradle.kts

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ dependencies {
2929
testLibrary("org.springframework.data:spring-data-couchbase:3.1.0.RELEASE")
3030
testLibrary("com.couchbase.client:encryption:1.0.0")
3131

32-
latestDepTestLibrary("org.springframework.data:spring-data-couchbase:3.1.+")
33-
latestDepTestLibrary("com.couchbase.client:java-client:2.+")
32+
latestDepTestLibrary("org.springframework.data:spring-data-couchbase:3.1.+") // see couchbase-3.1 module
33+
latestDepTestLibrary("com.couchbase.client:java-client:2.+") // see couchbase-3.1 module
3434
}
3535

3636
tasks {

instrumentation/elasticsearch/elasticsearch-api-client-7.16/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ dependencies {
4242
testImplementation("com.fasterxml.jackson.core:jackson-databind:2.14.2")
4343
testImplementation("org.testcontainers:elasticsearch")
4444

45-
latestDepTestLibrary("co.elastic.clients:elasticsearch-java:7.17.19")
45+
latestDepTestLibrary("co.elastic.clients:elasticsearch-java:7.17.19") // native on-by-default instrumentation after this version
4646
}
4747

4848
val latestDepTest = findProperty("testLatestDeps") as Boolean

instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/build.gradle.kts

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ dependencies {
4545
testLibrary("org.elasticsearch.plugin:transport-netty3-client:5.0.0")
4646
testLibrary("org.elasticsearch.client:transport:5.0.0")
4747

48-
latestDepTestLibrary("org.elasticsearch.plugin:transport-netty3-client:5.0.0")
49-
latestDepTestLibrary("org.elasticsearch.client:transport:5.0.0")
48+
latestDepTestLibrary("org.elasticsearch.plugin:transport-netty3-client:5.2.+") // see elasticsearch-transport-5.3 module
49+
latestDepTestLibrary("org.elasticsearch.client:transport:5.2.+") // see elasticsearch-transport-5.3 module
5050
}
5151

5252
tasks {

instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_0/Elasticsearch5NodeClientTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ static void setUp(@TempDir File esWorkingDir) {
4343
.put("transport.type", "netty3")
4444
.put("http.type", "netty3")
4545
.put(CLUSTER_NAME_SETTING.getKey(), clusterName)
46-
.put("discovery.type", "local")
4746
.build();
4847
testNode =
4948
new Node(

instrumentation/elasticsearch/elasticsearch-transport-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v5_0/Elasticsearch5TransportClientTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ static void setUp(@TempDir File esWorkingDir) {
4545
.put("transport.type", "netty3")
4646
.put("http.type", "netty3")
4747
.put(CLUSTER_NAME_SETTING.getKey(), clusterName)
48-
.put("discovery.type", "local")
4948
.build();
5049
testNode =
5150
new Node(

instrumentation/elasticsearch/elasticsearch-transport-5.3/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ dependencies {
6262

6363
latestDepTestLibrary("org.elasticsearch.plugin:transport-netty3-client:5.+") // see elasticsearch-transport-6.0 module
6464
latestDepTestLibrary("org.elasticsearch.client:transport:5.+") // see elasticsearch-transport-6.0 module
65-
latestDepTestLibrary("org.springframework.data:spring-data-elasticsearch:3.0.+")
65+
latestDepTestLibrary("org.springframework.data:spring-data-elasticsearch:3.0.+") // see elasticsearch-transport-6.0 module
6666
}
6767

6868
tasks {

instrumentation/grails-3.0/javaagent/build.gradle.kts

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ dependencies {
3838
testLibrary("org.springframework.boot:spring-boot-autoconfigure:$springBootVersion")
3939
testLibrary("org.springframework.boot:spring-boot-starter-tomcat:$springBootVersion")
4040

41-
latestDepTestLibrary("org.springframework.boot:spring-boot-autoconfigure:2.+")
42-
latestDepTestLibrary("org.springframework.boot:spring-boot-starter-tomcat:2.+")
41+
latestDepTestLibrary("org.springframework.boot:spring-boot-autoconfigure:2.+") // related dependency
42+
latestDepTestLibrary("org.springframework.boot:spring-boot-starter-tomcat:2.+") // related dependency
4343
}
4444

4545
// testing-common pulls in groovy 4 and spock as dependencies, exclude them

instrumentation/graphql-java/graphql-java-12.0/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ dependencies {
2222

2323
testImplementation(project(":instrumentation:graphql-java:graphql-java-common:testing"))
2424

25-
latestDepTestLibrary("com.graphql-java:graphql-java:19.+")
25+
latestDepTestLibrary("com.graphql-java:graphql-java:19.+") // see graphql-java-20.0 module
2626
}

instrumentation/graphql-java/graphql-java-12.0/library/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ dependencies {
88

99
testImplementation(project(":instrumentation:graphql-java:graphql-java-common:testing"))
1010

11-
latestDepTestLibrary("com.graphql-java:graphql-java:19.+")
11+
latestDepTestLibrary("com.graphql-java:graphql-java:19.+") // see graphql-java-20.0 module
1212
}

instrumentation/hibernate/hibernate-6.0/spring-testing/build.gradle.kts

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ dependencies {
1818
testImplementation("org.springframework.data:spring-data-jpa:3.0.0")
1919

2020
springAgent("org.springframework:spring-instrument:6.0.7")
21-
22-
latestDepTestLibrary("org.hibernate:hibernate-core:6.2.+")
2321
}
2422

2523
otelJava {

instrumentation/jaxrs-client/jaxrs-client-2.0-testing/build.gradle.kts

+3
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ dependencies {
1818
testInstrumentation(project(":instrumentation:http-url-connection:javaagent"))
1919
testInstrumentation(project(":instrumentation:java-http-client:javaagent"))
2020

21+
// there's no test coverage beyond this, but there's no reason to believe it wouldn't work
22+
// also note that this isn't really documented on supported-libraries.md because there's not
23+
// really any instrumentation for it, as it just relies on other http client instrumentations
2124
latestDepTestLibrary("org.glassfish.jersey.inject:jersey-hk2:2.+")
2225
latestDepTestLibrary("org.glassfish.jersey.core:jersey-client:2.+")
2326
latestDepTestLibrary("org.jboss.resteasy:resteasy-client:3.0.26.Final")

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-cxf-3.2/javaagent/build.gradle.kts

+4-4
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ dependencies {
4646
testLibrary("org.apache.cxf:cxf-rt-transports-http-jetty:3.2.0")
4747
testLibrary("org.apache.cxf:cxf-rt-ws-policy:3.2.0")
4848

49-
latestDepTestLibrary("org.eclipse.jetty:jetty-webapp:10.+")
50-
latestDepTestLibrary("org.apache.cxf:cxf-rt-frontend-jaxrs:3.+")
51-
latestDepTestLibrary("org.apache.cxf:cxf-rt-transports-http-jetty:3.+")
52-
latestDepTestLibrary("org.apache.cxf:cxf-rt-ws-policy:3.+")
49+
latestDepTestLibrary("org.eclipse.jetty:jetty-webapp:10.+") // documented limitation
50+
latestDepTestLibrary("org.apache.cxf:cxf-rt-frontend-jaxrs:3.+") // documented limitation
51+
latestDepTestLibrary("org.apache.cxf:cxf-rt-transports-http-jetty:3.+") // documented limitation
52+
latestDepTestLibrary("org.apache.cxf:cxf-rt-ws-policy:3.+") // documented limitation
5353
}
5454

5555
tasks.withType<Test>().configureEach {

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-3.0/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ dependencies {
6767
latestDepTestLibrary("org.jboss.resteasy:resteasy-undertow:3.0.+") { // see jaxrs-3.0-resteasy-3.1 module
6868
exclude("org.jboss.resteasy", "resteasy-client")
6969
}
70-
latestDepTestLibrary("io.undertow:undertow-servlet:2.2.24.Final") // 2.3 switches to Servlet 5 / Jakarta namespace
70+
latestDepTestLibrary("io.undertow:undertow-servlet:2.2.24.Final") // see jaxrs-3.0-resteasy-3.1 module
7171
}
7272

7373
tasks {

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-3.1/javaagent/build.gradle.kts

+3-3
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ dependencies {
6060
testLibrary("org.jboss.resteasy:resteasy-servlet-initializer:3.1.0.Final")
6161

6262
// artifact name changed from 'resteasy-jaxrs' to 'resteasy-core' starting from version 4.0.0
63-
latestDepTestLibrary("org.jboss.resteasy:resteasy-core:5.+")
64-
latestDepTestLibrary("org.jboss.resteasy:resteasy-servlet-initializer:5.+")
65-
latestDepTestLibrary("org.jboss.resteasy:resteasy-undertow:5.+") {
63+
latestDepTestLibrary("org.jboss.resteasy:resteasy-core:5.+") // documented limitation
64+
latestDepTestLibrary("org.jboss.resteasy:resteasy-servlet-initializer:5.+") // documented limitation
65+
latestDepTestLibrary("org.jboss.resteasy:resteasy-undertow:5.+") { // documented limitation
6666
exclude("org.jboss.resteasy", "resteasy-client")
6767
}
6868
}

instrumentation/jaxws/jaxws-2.0-metro-2.2-testing/build.gradle.kts

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ dependencies {
1818
testInstrumentation(project(":instrumentation:servlet:servlet-3.0:javaagent"))
1919
testInstrumentation(project(":instrumentation:jetty:jetty-8.0:javaagent"))
2020

21-
latestDepTestLibrary("com.sun.xml.ws:jaxws-rt:2.+")
22-
latestDepTestLibrary("com.sun.xml.stream.buffer:streambuffer:1.+")
21+
latestDepTestLibrary("com.sun.xml.ws:jaxws-rt:2.+") // see jaxws-3.0-metro-2.2-testing module
22+
latestDepTestLibrary("com.sun.xml.stream.buffer:streambuffer:1.+") // see jaxws-3.0-metro-2.2-testing module
2323
}
2424

2525
tasks.withType<Test>().configureEach {

instrumentation/jaxws/jaxws-cxf-3.0/javaagent/build.gradle.kts

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ dependencies {
4040
testImplementation("javax.annotation:javax.annotation-api:1.2")
4141
testImplementation("com.sun.xml.messaging.saaj:saaj-impl:1.5.2")
4242

43-
latestDepTestLibrary("org.apache.cxf:cxf-rt-frontend-jaxws:3.+")
44-
latestDepTestLibrary("org.apache.cxf:cxf-rt-transports-http:3.+")
43+
latestDepTestLibrary("org.apache.cxf:cxf-rt-frontend-jaxws:3.+") // documented limitation
44+
latestDepTestLibrary("org.apache.cxf:cxf-rt-transports-http:3.+") // documented limitation
4545
}
4646

4747
tasks.withType<Test>().configureEach {

instrumentation/jdbc/javaagent/build.gradle.kts

+2-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ dependencies {
3232
testLibrary("com.zaxxer:HikariCP:2.4.0")
3333
testLibrary("com.mchange:c3p0:0.9.5")
3434

35-
latestDepTestLibrary("org.apache.derby:derby:10.14.+")
35+
// some classes in earlier versions of derby were split out into derbytools in later versions
36+
latestDepTestLibrary("org.apache.derby:derbytools:+")
3637

3738
testImplementation(project(":instrumentation:jdbc:testing"))
3839

instrumentation/jetty-httpclient/jetty-httpclient-9.2/library/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ dependencies {
1010

1111
testImplementation(project(":instrumentation:jetty-httpclient::jetty-httpclient-9.2:testing"))
1212

13-
latestDepTestLibrary("org.eclipse.jetty:jetty-client:9.+")
13+
latestDepTestLibrary("org.eclipse.jetty:jetty-client:9.+") // documented limitation
1414
}

instrumentation/jetty/jetty-11.0/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ dependencies {
2222

2323
// jetty-servlet does not exist in jetty 12, so we don't need to explicitly pin it to 11.+
2424
testLibrary("org.eclipse.jetty:jetty-servlet:11.0.0")
25-
latestDepTestLibrary("org.eclipse.jetty:jetty-server:11.+")
25+
latestDepTestLibrary("org.eclipse.jetty:jetty-server:11.+") // see jetty-12.0 module
2626
}
2727

2828
otelJava {

instrumentation/jsf/jsf-mojarra-3.0/javaagent/build.gradle.kts

+3-4
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,10 @@ dependencies {
2727
testInstrumentation(project(":instrumentation:servlet:servlet-5.0:javaagent"))
2828
testInstrumentation(project(":instrumentation:servlet:servlet-common:javaagent"))
2929

30-
latestDepTestLibrary("jakarta.el:jakarta.el-api:4.+")
31-
latestDepTestLibrary("jakarta.faces:jakarta.faces-api:3.+")
32-
latestDepTestLibrary("org.glassfish:jakarta.faces:3.+")
3330
// JSF 4+ requires CDI instead of BeanManager, the test should be upgraded first
34-
// latestDepTestLibrary("org.glassfish:jakarta.faces:4.+")
31+
latestDepTestLibrary("jakarta.el:jakarta.el-api:4.+") // documented limitation
32+
latestDepTestLibrary("jakarta.faces:jakarta.faces-api:3.+") // documented limitation
33+
latestDepTestLibrary("org.glassfish:jakarta.faces:3.+") // documented limitation
3534
}
3635

3736
tasks {

instrumentation/jsf/jsf-myfaces-3.0/javaagent/build.gradle.kts

+3-4
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,10 @@ dependencies {
2727
testInstrumentation(project(":instrumentation:servlet:servlet-5.0:javaagent"))
2828
testInstrumentation(project(":instrumentation:servlet:servlet-common:javaagent"))
2929

30-
latestDepTestLibrary("jakarta.el:jakarta.el-api:4.+")
31-
latestDepTestLibrary("org.apache.myfaces.core:myfaces-api:3.+")
32-
latestDepTestLibrary("org.apache.myfaces.core:myfaces-impl:3.+")
3330
// JSF 4+ requires CDI instead of BeanManager, the test should be upgraded first
34-
// latestDepTestLibrary("org.apache.myfaces.core:myfaces-impl:4.+")
31+
latestDepTestLibrary("jakarta.el:jakarta.el-api:4.+") // documented limitation
32+
latestDepTestLibrary("org.apache.myfaces.core:myfaces-api:3.+") // documented limitation
33+
latestDepTestLibrary("org.apache.myfaces.core:myfaces-impl:3.+") // documented limitation
3534
}
3635

3736
tasks {

instrumentation/jsp-2.3/javaagent/build.gradle.kts

+5-7
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ muzzle {
2828
dependencies {
2929
// compiling against tomcat 7.0.20 because there seems to be some issues with Tomcat's dependency < 7.0.20
3030
compileOnly("org.apache.tomcat:tomcat-jasper:7.0.20")
31-
compileOnly("javax.servlet.jsp:javax.servlet.jsp-api:2.3.0")
32-
compileOnly("javax.servlet:javax.servlet-api:3.1.0")
31+
library("javax.servlet.jsp:javax.servlet.jsp-api:2.3.0")
32+
library("javax.servlet:javax.servlet-api:3.1.0")
3333

3434
testInstrumentation(project(":instrumentation:servlet:servlet-3.0:javaagent"))
3535
testInstrumentation(project(":instrumentation:servlet:servlet-javax-common:javaagent"))
@@ -40,11 +40,9 @@ dependencies {
4040
testLibrary("org.apache.tomcat.embed:tomcat-embed-logging-juli:7.0.37")
4141
testLibrary("org.apache.tomcat.embed:tomcat-embed-jasper:7.0.37")
4242

43-
latestDepTestLibrary("javax.servlet.jsp:javax.servlet.jsp-api:+")
44-
latestDepTestLibrary("javax.servlet:javax.servlet-api:+")
45-
latestDepTestLibrary("org.apache.tomcat.embed:tomcat-embed-core:9.+")
46-
latestDepTestLibrary("org.apache.tomcat.embed:tomcat-embed-jasper:9.+")
47-
latestDepTestLibrary("org.apache.tomcat.embed:tomcat-embed-logging-juli:9.+")
43+
latestDepTestLibrary("org.apache.tomcat.embed:tomcat-embed-core:9.+") // documented limitation
44+
latestDepTestLibrary("org.apache.tomcat.embed:tomcat-embed-jasper:9.+") // documented limitation
45+
latestDepTestLibrary("org.apache.tomcat.embed:tomcat-embed-logging-juli:9.+") // documented limitation
4846
}
4947

5048
tasks.withType<Test>().configureEach {

instrumentation/ktor/ktor-2.0/javaagent/build.gradle.kts

+4-4
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ dependencies {
4646
testLibrary("io.ktor:ktor-server-netty:$ktorVersion")
4747
testLibrary("io.ktor:ktor-client-cio:$ktorVersion")
4848

49-
latestDepTestLibrary("io.ktor:ktor-client-core:2.+")
50-
latestDepTestLibrary("io.ktor:ktor-server-core:2.+")
51-
latestDepTestLibrary("io.ktor:ktor-server-netty:2.+")
52-
latestDepTestLibrary("io.ktor:ktor-client-cio:2.+")
49+
latestDepTestLibrary("io.ktor:ktor-client-core:2.+") // see ktor-3.0 module
50+
latestDepTestLibrary("io.ktor:ktor-server-core:2.+") // see ktor-3.0 module
51+
latestDepTestLibrary("io.ktor:ktor-server-netty:2.+") // see ktor-3.0 module
52+
latestDepTestLibrary("io.ktor:ktor-client-cio:2.+") // see ktor-3.0 module
5353
}
5454

5555
kotlin {

instrumentation/ktor/ktor-2.0/library/build.gradle.kts

+4-4
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ dependencies {
2424
testLibrary("io.ktor:ktor-server-netty:$ktorVersion")
2525
testLibrary("io.ktor:ktor-client-cio:$ktorVersion")
2626

27-
latestDepTestLibrary("io.ktor:ktor-client-core:2.+")
28-
latestDepTestLibrary("io.ktor:ktor-server-core:2.+")
29-
latestDepTestLibrary("io.ktor:ktor-server-netty:2.+")
30-
latestDepTestLibrary("io.ktor:ktor-client-cio:2.+")
27+
latestDepTestLibrary("io.ktor:ktor-client-core:2.+") // see ktor-3.0 module
28+
latestDepTestLibrary("io.ktor:ktor-server-core:2.+") // see ktor-3.0 module
29+
latestDepTestLibrary("io.ktor:ktor-server-netty:2.+") // see ktor-3.0 module
30+
latestDepTestLibrary("io.ktor:ktor-client-cio:2.+") // see ktor-3.0 module
3131
}
3232

3333
kotlin {

instrumentation/kubernetes-client-7.0/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ dependencies {
1616

1717
testInstrumentation(project(":instrumentation:okhttp:okhttp-3.0:javaagent"))
1818

19-
latestDepTestLibrary("io.kubernetes:client-java-api:19.+")
19+
latestDepTestLibrary("io.kubernetes:client-java-api:19.+") // see test suite below
2020
}
2121

2222
testing {

instrumentation/netty/netty-3.8/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ dependencies {
3232
testLibrary("com.ning:async-http-client:1.8.0")
3333

3434
latestDepTestLibrary("io.netty:netty:3.+") // see netty-4.0 module
35-
latestDepTestLibrary("com.ning:async-http-client:1.9.+")
35+
latestDepTestLibrary("com.ning:async-http-client:1.9.+") // see netty-4.0 module
3636
}
3737

3838
// We need to force the dependency to the earliest supported version because other libraries declare newer versions.

instrumentation/play/play-mvc/play-mvc-2.4/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ dependencies {
4545

4646
latestDepTestLibrary("com.typesafe.play:play-java_2.11:2.5.+") // see play-2.6 module
4747
latestDepTestLibrary("com.typesafe.play:play-java-ws_2.11:2.5.+") // see play-2.6 module
48-
latestDepTestLibrary("com.typesafe.play:play-test_2.11:2.5.+")
48+
latestDepTestLibrary("com.typesafe.play:play-test_2.11:2.5.+") // see play-2.6 module
4949
}
5050

5151
testing {

0 commit comments

Comments
 (0)