Skip to content

Commit 1a6a84b

Browse files
committed
fix comment
1 parent a9b1d48 commit 1a6a84b

File tree

1 file changed

+1
-3
lines changed
  • instrumentation/log4j/log4j-context-data/log4j-context-data-common/testing/src/main/java/io/opentelemetry/instrumentation/log4j/contextdata

1 file changed

+1
-3
lines changed

instrumentation/log4j/log4j-context-data/log4j-context-data-common/testing/src/main/java/io/opentelemetry/instrumentation/log4j/contextdata/Log4j2Test.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -138,18 +138,17 @@ void testIdsWhenSpan() {
138138
void testNoOverrideTraceId() {
139139
Logger logger = LogManager.getLogger("TestLogger");
140140

141-
AtomicReference<Span> spanParent = new AtomicReference<>();
142141
ThreadContext.put(getLoggingKey("trace_id"), "test_traceId");
143142
ThreadContext.put(getLoggingKey("span_id"), "test_spanId");
144143
ThreadContext.put(getLoggingKey("trace_flags"), "test_traceFlag");
145144
getInstrumentationExtension()
146145
.runWithSpan(
147146
"test",
148147
() -> {
149-
spanParent.set(Span.current());
150148
logger.info("log span parent");
151149
});
152150
List<ListAppender.LoggedEvent> events = ListAppender.get().getEvents();
151+
ThreadContext.clearAll();
153152
assertThat(events.size()).isEqualTo(1);
154153
assertThat(events.get(0).getMessage()).isEqualTo("log span parent");
155154
assertThat(events.get(0).getContextData().get(getLoggingKey("trace_id")))
@@ -158,6 +157,5 @@ void testNoOverrideTraceId() {
158157
.isEqualTo("test_spanId");
159158
assertThat(events.get(0).getContextData().get(getLoggingKey("trace_flags")))
160159
.isEqualTo("test_traceFlag");
161-
ThreadContext.clearAll();
162160
}
163161
}

0 commit comments

Comments
 (0)