Skip to content

Commit 3277ded

Browse files
committed
address review comments
1 parent 720b15d commit 3277ded

File tree

2 files changed

+2
-5
lines changed
  • instrumentation/spring/spring-boot-autoconfigure/src

2 files changed

+2
-5
lines changed

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/logging/LogbackAppenderInstaller.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ private static void addMdcAppender(
172172
initializeMdcAppenderFromProperties(applicationEnvironmentPreparedEvent, openTelemetryAppender);
173173
openTelemetryAppender.start();
174174
logger.addAppender(openTelemetryAppender);
175-
// move existing appenders under otel mdc appender
175+
// move existing appenders under otel mdc appender, so they could observe the added mdc values
176176
for (Iterator<Appender<ILoggingEvent>> i = logger.iteratorForAppenders(); i.hasNext(); ) {
177177
Appender<ILoggingEvent> appender = i.next();
178178
if (appender != openTelemetryAppender) {

instrumentation/spring/spring-boot-autoconfigure/src/testLogbackAppender/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/logging/CustomListAppender.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@
88
import ch.qos.logback.classic.spi.ILoggingEvent;
99
import ch.qos.logback.core.read.ListAppender;
1010

11-
/**
12-
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
13-
* any time.
14-
*/
11+
@SuppressWarnings("OtelInternalJavadoc")
1512
public class CustomListAppender extends ListAppender<ILoggingEvent> {
1613
public static boolean lastLogHadTraceId;
1714

0 commit comments

Comments
 (0)