Skip to content

Commit 3c32c6a

Browse files
authored
Make Play smoke test work on Java 17 (#12464)
1 parent 67cb5f1 commit 3c32c6a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

smoke-tests/images/play/build.gradle.kts

+6
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ plugins {
66
id("otel.spotless-conventions")
77

88
id("com.google.cloud.tools.jib")
9+
// TODO (trask) this plugin doesn't support Play 2.9+, see https://github.com/gradle/playframework/issues/185
10+
// once play 3.1 is released, we can update to https://github.com/orgs/playframework/discussions/12338
911
id("org.gradle.playframework") version "0.14"
1012
}
1113

@@ -23,6 +25,10 @@ play {
2325

2426
dependencies {
2527
implementation("com.typesafe.play:play-guice_$scalaVer:$playVer")
28+
// Guice 5.1 is needed for Java 17 support on Play 2.8, see https://github.com/playframework/playframework/releases/tag/2.8.15
29+
// TODO (trask) remove these version overrides after updating to Play 2.9
30+
implementation("com.google.inject:guice:5.1.0")
31+
implementation("com.google.inject.extensions:guice-assistedinject:5.1.0")
2632
implementation("com.typesafe.play:play-logback_$scalaVer:$playVer")
2733
implementation("com.typesafe.play:filters-helpers_$scalaVer:$playVer")
2834
}

0 commit comments

Comments
 (0)