including prometheus conditionally doesn't seem to work - and it not gaining that much

Author: zeitlinger

instrumentation/spring/spring-boot-actuator-autoconfigure-2.0/javaagent/build.gradle.kts

@@ -15,6 +15,7 @@ muzzle {
 dependencies {
   library("org.springframework.boot:spring-boot-actuator-autoconfigure:2.0.0.RELEASE")
   library("io.micrometer:micrometer-core:1.5.0")
+  runtimeOnly("io.micrometer:micrometer-registry-prometheus:1.0.1")
 
   implementation(project(":instrumentation:micrometer:micrometer-1.5:javaagent"))
 
@@ -48,18 +49,4 @@ if (!latestDepTest) {
       force("org.slf4j:slf4j-api:1.7.36")
     }
   }
-
-  // this dependency adds the old io.micrometer.prometheus.PrometheusMeterRegistry,
-  // which is not supported by the latest version of spring boot
-  tasks {
-    val testPrometheus by registering(Test::class) {
-      dependencies {
-        runtimeOnly("io.micrometer:micrometer-registry-prometheus:1.0.1")
-      }
-    }
-
-    check {
-      dependsOn(testPrometheus)
-    }
-  }
 }

instrumentation/spring/spring-boot-actuator-autoconfigure-2.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/actuator/v2_0/ActuatorTest.java

@@ -66,14 +66,5 @@ void shouldInjectOtelMeterRegistry() {
 
     String last = list.get(list.size() - 1).getClass().getSimpleName();
     assertThat(last).isEqualTo("OpenTelemetryMeterRegistry");
-
-    try {
-      Class.forName("io.micrometer.prometheusmetrics.PrometheusMeterRegistry");
-      assertThat(registries)
-          .extracting(r -> r.getClass().getSimpleName())
-          .contains("PrometheusMeterRegistry");
-    } catch (ClassNotFoundException e) {
-      // not testing prometheus
-    }
   }
 }