error.type and db.response.status_code all dbs

Author: zeitlinger

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientCommonAttributesGetter.java

@@ -54,10 +54,4 @@ default String getResponseStatusFromException(Throwable throwable) {
   default String getResponseStatus(RESPONSE response) {
     return null;
   }
-
-  @Nullable
-  default String httpStatusToResponseStatus(int httpStatus) {
-    int hundreds = httpStatus / 100;
-    return hundreds == 4 || hundreds == 5 ? Integer.toString(httpStatus) : null;
-  }
 }

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbResponseStatusUtil.java

@@ -0,0 +1,14 @@
+package io.opentelemetry.instrumentation.api.incubator.semconv.db;
+
+import javax.annotation.Nullable;
+
+/** Utility class for database response status. */
+public class DbResponseStatusUtil {
+  private DbResponseStatusUtil() {
+  }
+
+  @Nullable
+  public static String httpStatusToResponseStatus(int httpStatus) {
+    return httpStatus >= 400 && httpStatus< 600 ? Integer.toString(httpStatus) : null;
+  }
+}

instrumentation/elasticsearch/elasticsearch-rest-common/library/src/main/java/io/opentelemetry/instrumentation/elasticsearch/rest/internal/ElasticsearchDbAttributesGetter.java

@@ -15,6 +15,7 @@
 import java.util.logging.Logger;
 import java.util.stream.Collectors;
 import javax.annotation.Nullable;
+import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbResponseStatusUtil;
 import org.apache.http.HttpEntity;
 import org.elasticsearch.client.Response;
 
@@ -95,6 +96,6 @@ public String getDbOperationName(ElasticsearchRestRequest request) {
 
   @Override
   public String getResponseStatus(Response response) {
-    return httpStatusToResponseStatus(response.getStatusLine().getStatusCode());
+    return DbResponseStatusUtil.httpStatusToResponseStatus(response.getStatusLine().getStatusCode());
   }
 }

instrumentation/opensearch/opensearch-rest-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/rest/OpenSearchRestAttributesGetter.java

@@ -6,6 +6,7 @@
 package io.opentelemetry.javaagent.instrumentation.opensearch.rest;
 
 import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbClientAttributesGetter;
+import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbResponseStatusUtil;
 import io.opentelemetry.semconv.incubating.DbIncubatingAttributes;
 import javax.annotation.Nullable;
 import org.opensearch.client.Response;
@@ -53,6 +54,6 @@ public String getDbOperationName(OpenSearchRestRequest request) {
 
   @Override
   public String getResponseStatus(Response response) {
-    return httpStatusToResponseStatus(response.getStatusLine().getStatusCode());
+    return DbResponseStatusUtil.httpStatusToResponseStatus(response.getStatusLine().getStatusCode());
   }
 }