Skip to content

Commit 51f0e17

Browse files
authored
Temporarily limit instrumentation to exclude Spring 6 (#7202)
Tracking issue to support Spring 6 #7203
1 parent 5711500 commit 51f0e17

File tree

8 files changed

+14
-5
lines changed

8 files changed

+14
-5
lines changed

gradle-plugins/src/main/kotlin/io.opentelemetry.instrumentation.muzzle-check.gradle.kts

+1
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,7 @@ fun inverseOf(muzzleDirective: MuzzleDirective, system: RepositorySystem, sessio
351351

352352
for (version in filterVersions(allRangeResult, muzzleDirective.normalizedSkipVersions)) {
353353
val inverseDirective = objects.newInstance(MuzzleDirective::class).apply {
354+
name.set(muzzleDirective.name)
354355
group.set(muzzleDirective.group)
355356
module.set(muzzleDirective.module)
356357
classifier.set(muzzleDirective.classifier)

instrumentation/spring/spring-data-1.8/javaagent/build.gradle.kts

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ dependencies {
3737
testImplementation("org.hsqldb:hsqldb:2.0.0")
3838
testLibrary("org.hibernate:hibernate-entitymanager:4.3.0.Final")
3939

40+
latestDepTestLibrary("org.springframework:spring-test:5.+")
4041
latestDepTestLibrary("org.hibernate:hibernate-entitymanager:5.+")
4142
}
4243

instrumentation/spring/spring-jms-2.0/javaagent/build.gradle.kts

+2
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ dependencies {
5151
exclude("org.jboss.naming", "jnpserver")
5252
}
5353

54+
latestDepTestLibrary("org.springframework:spring-jms:5.+")
55+
5456
// this is just to avoid a bit more copy-pasting
5557
add("testReceiveSpansDisabledImplementation", sourceSets["test"].output)
5658
}

instrumentation/spring/spring-rmi-4.0/javaagent/build.gradle.kts

+4-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ muzzle {
66
pass {
77
group.set("org.springframework")
88
module.set("spring-context")
9-
versions.set("[4.0.0.RELEASE,)")
9+
versions.set("[4.0.0.RELEASE,6)")
1010
}
1111
}
1212

@@ -20,6 +20,9 @@ dependencies {
2020
library("org.springframework:spring-context:4.0.0.RELEASE")
2121
library("org.springframework:spring-aop:4.0.0.RELEASE")
2222
testLibrary("org.springframework.boot:spring-boot:1.1.0.RELEASE")
23+
24+
latestDepTestLibrary("org.springframework:spring-context:5.+")
25+
latestDepTestLibrary("org.springframework:spring-aop:5.+")
2326
}
2427

2528
tasks.withType<Test>().configureEach {

instrumentation/spring/spring-scheduling-3.1/javaagent/build.gradle.kts

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ dependencies {
1616
// classes and packages to be imported. Versions 3.1.0+ work with the instrumentation.
1717
library("org.springframework:spring-context:3.1.0.RELEASE")
1818
testLibrary("org.springframework:spring-context:3.2.3.RELEASE")
19+
20+
latestDepTestLibrary("org.springframework:spring-context:5.+")
1921
}
2022

2123
tasks.withType<Test>().configureEach {

instrumentation/spring/spring-web-3.1/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ muzzle {
66
pass {
77
group.set("org.springframework")
88
module.set("spring-web")
9-
versions.set("[3.1.0.RELEASE,]")
9+
versions.set("[3.1.0.RELEASE,)")
1010
// these versions depend on javax.faces:jsf-api:1.1 which was released as pom only
1111
skip("1.2.1", "1.2.2", "1.2.3", "1.2.4")
1212
assertInverse.set(true)

instrumentation/spring/spring-webflux-5.0/javaagent/build.gradle.kts

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ muzzle {
77
name.set("webflux_5.0.0+_with_netty_0.8.0")
88
group.set("org.springframework")
99
module.set("spring-webflux")
10-
versions.set("[5.0.0.RELEASE,)")
10+
versions.set("[5.0.0.RELEASE,6)")
1111
assertInverse.set(true)
1212
extraDependency("io.projectreactor.netty:reactor-netty:0.8.0.RELEASE")
1313
}
@@ -16,7 +16,7 @@ muzzle {
1616
name.set("webflux_5.0.0_with_ipc_0.7.0")
1717
group.set("org.springframework")
1818
module.set("spring-webflux")
19-
versions.set("[5.0.0.RELEASE,)")
19+
versions.set("[5.0.0.RELEASE,6)")
2020
assertInverse.set(true)
2121
extraDependency("io.projectreactor.ipc:reactor-netty:0.7.0.RELEASE")
2222
}

instrumentation/spring/spring-webmvc-3.1/javaagent/build.gradle.kts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ muzzle {
66
pass {
77
group.set("org.springframework")
88
module.set("spring-webmvc")
9-
versions.set("[3.1.0.RELEASE,]")
9+
versions.set("[3.1.0.RELEASE,6)")
1010
// these versions depend on org.springframework:spring-web which has a bad dependency on
1111
// javax.faces:jsf-api:1.1 which was released as pom only
1212
skip("1.2.1", "1.2.2", "1.2.3", "1.2.4")

0 commit comments

Comments
 (0)