Fix gc duration metric in runtime-telemetry-java17

Author: laurit

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java17/internal/DurationUtil.java

@@ -14,17 +14,12 @@
  */
 public final class DurationUtil {
   private static final double NANOS_PER_SECOND = TimeUnit.SECONDS.toNanos(1);
-  private static final double MILLIS_PER_SECOND = TimeUnit.SECONDS.toMillis(1);
 
   /** Returns the duration as seconds, with fractional part included. */
   public static double toSeconds(Duration duration) {
     double epochSecs = (double) duration.getSeconds();
     return epochSecs + duration.getNano() / NANOS_PER_SECOND;
   }
 
-  public static double millisToSeconds(long milliseconds) {
-    return milliseconds / MILLIS_PER_SECOND;
-  }
-
   private DurationUtil() {}
 }

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java17/internal/garbagecollection/G1GarbageCollectionHandler.java

@@ -41,7 +41,7 @@ public G1GarbageCollectionHandler(Meter meter) {
 
   @Override
   public void accept(RecordedEvent ev) {
-    histogram.record(DurationUtil.millisToSeconds(ev.getLong(Constants.DURATION)), ATTR);
+    histogram.record(DurationUtil.toSeconds(ev.getDuration()), ATTR);
   }
 
   @Override

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java17/internal/garbagecollection/OldGarbageCollectionHandler.java

@@ -41,7 +41,7 @@ public OldGarbageCollectionHandler(Meter meter, String gc) {
 
   @Override
   public void accept(RecordedEvent ev) {
-    histogram.record(DurationUtil.millisToSeconds(ev.getLong(Constants.DURATION)), attributes);
+    histogram.record(DurationUtil.toSeconds(ev.getDuration()), attributes);
   }
 
   @Override

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java17/internal/garbagecollection/YoungGarbageCollectionHandler.java

@@ -42,7 +42,7 @@ public YoungGarbageCollectionHandler(Meter meter, String gc) {
 
   @Override
   public void accept(RecordedEvent ev) {
-    histogram.record(DurationUtil.millisToSeconds(ev.getLong(Constants.DURATION)), attributes);
+    histogram.record(DurationUtil.toSeconds(ev.getDuration()), attributes);
   }
 
   @Override

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/test/java/io/opentelemetry/instrumentation/runtimemetrics/java17/internal/DurationUtilTest.java

@@ -8,7 +8,6 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 import java.time.Duration;
-import java.util.concurrent.TimeUnit;
 import org.junit.jupiter.api.Test;
 
 class DurationUtilTest {
@@ -19,10 +18,4 @@ void convertDurationToSeconds() {
     double seconds = DurationUtil.toSeconds(duration);
     assertThat(seconds).isEqualTo(7.000000144);
   }
-
-  @Test
-  void convertMillisSeconds() {
-    double seconds = DurationUtil.millisToSeconds(TimeUnit.SECONDS.toMillis(5));
-    assertThat(seconds).isEqualTo(5);
-  }
 }