use privileged mode

Author: zeitlinger

javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/OpenTelemetryAgent.java

@@ -5,7 +5,6 @@
 
 package io.opentelemetry.javaagent;
 
-import io.opentelemetry.javaagent.bootstrap.AgentArgUtil;
 import io.opentelemetry.javaagent.bootstrap.AgentInitializer;
 import io.opentelemetry.javaagent.bootstrap.InstrumentationHolder;
 import io.opentelemetry.javaagent.bootstrap.JavaagentFileHolder;
@@ -54,11 +53,10 @@ public static void agentmain(String agentArgs, Instrumentation inst) {
   private static void startAgent(
       Instrumentation inst, @Nullable String agentArgs, boolean fromPremain) {
     try {
-      AgentArgUtil.setSystemProperties(agentArgs);
       File javaagentFile = installBootstrapJar(inst);
       InstrumentationHolder.setInstrumentation(inst);
       JavaagentFileHolder.setJavaagentFile(javaagentFile);
-      AgentInitializer.initialize(inst, javaagentFile, fromPremain);
+      AgentInitializer.initialize(inst, javaagentFile, fromPremain, agentArgs);
     } catch (Throwable ex) {
       // Don't rethrow.  We don't have a log manager here, so just print.
       System.err.println("ERROR " + OpenTelemetryAgent.class.getName());

javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/AgentInitializer.java

@@ -28,12 +28,19 @@ public final class AgentInitializer {
   private static boolean isSecurityManagerSupportEnabled = false;
   private static volatile boolean agentStarted = false;
 
-  public static void initialize(Instrumentation inst, File javaagentFile, boolean fromPremain)
+  public static void initialize(
+      Instrumentation inst, File javaagentFile, boolean fromPremain, String agentArgs)
       throws Exception {
     if (agentClassLoader != null) {
       return;
     }
 
+    doPrivileged(
+        () -> {
+          AgentArgUtil.setSystemProperties(agentArgs);
+          return null;
+        });
+
     // we expect that at this point agent jar has been appended to boot class path and all agent
     // classes are loaded in boot loader
     if (AgentInitializer.class.getClassLoader() != null) {