Improve error handling in flaky test reporter (#13221)

Author: laurit

test-report/src/main/java/io/opentelemetry/instrumentation/testreport/FlakyTestReporter.java

@@ -47,19 +47,8 @@ public class FlakyTestReporter {
   private int errorCount;
   private final List<FlakyTest> flakyTests = new ArrayList<>();
 
-  private static class FlakyTest {
-    final String testClassName;
-    final String testName;
-    final String timestamp;
-    final String message;
-
-    FlakyTest(String testClassName, String testName, String timestamp, String message) {
-      this.testClassName = testClassName;
-      this.testName = testName;
-      this.timestamp = timestamp;
-      this.message = message;
-    }
-  }
+  private record FlakyTest(
+      String testClassName, String testName, String timestamp, String message) {}
 
   private void addFlakyTest(
       String testClassName, String testName, String timestamp, String message) {
@@ -160,6 +149,15 @@ private static String getAttributeValue(Node node, String attributeName) {
     return value != null ? value.getNodeValue() : null;
   }
 
+  private static class BaseFileVisitor<T> extends SimpleFileVisitor<T> {
+    @Override
+    public FileVisitResult visitFileFailed(T file, IOException exception) {
+      System.err.println("Failed to visit " + file.toString());
+      exception.printStackTrace();
+      return CONTINUE;
+    }
+  }
+
   private void scanTestResults(Path buildDir) throws IOException {
     Path testResults = buildDir.resolve("test-results");
     if (!Files.exists(testResults)) {
@@ -168,7 +166,7 @@ private void scanTestResults(Path buildDir) throws IOException {
 
     Files.walkFileTree(
         testResults,
-        new SimpleFileVisitor<>() {
+        new BaseFileVisitor<>() {
           @Override
           public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
             String name = file.getFileName().toString();
@@ -178,21 +176,14 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
 
             return CONTINUE;
           }
-
-          @Override
-          public FileVisitResult visitFileFailed(Path file, IOException exception) {
-            System.err.println("Failed to visit " + file.toString());
-            exception.printStackTrace();
-            return CONTINUE;
-          }
         });
   }
 
   private static FlakyTestReporter scan(Path path) throws IOException {
     FlakyTestReporter reporter = new FlakyTestReporter();
     Files.walkFileTree(
         path,
-        new SimpleFileVisitor<>() {
+        new BaseFileVisitor<>() {
           @Override
           public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs)
               throws IOException {