review

Author: zeitlinger

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java17/RuntimeMetrics.java

@@ -101,7 +101,7 @@ private JfrRuntimeMetrics(OpenTelemetry openTelemetry, Predicate<JfrFeature> fea
             recordingStream.onEvent(handler.getEventName(), handler);
           });
       recordingStream.onMetadata(event -> startUpLatch.countDown());
-      Thread daemonRunner = new Thread(recordingStream::start, "JFR-Metrics-Runner");
+      Thread daemonRunner = new Thread(recordingStream::start, "OpenTelemetry JFR-Metrics-Runner");
       daemonRunner.setDaemon(true);
       daemonRunner.start();
     }

instrumentation/runtime-telemetry/runtime-telemetry-java17/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java17/RuntimeMetricsBuilder.java

@@ -26,7 +26,7 @@ public final class RuntimeMetricsBuilder {
   private boolean enableExperimentalJmxTelemetry = false;
   private Consumer<Runnable> shutdownHook =
       runnable -> {
-        Runtime.getRuntime().addShutdownHook(new Thread(runnable, "RuntimeMetricsShutdownHook"));
+        Runtime.getRuntime().addShutdownHook(new Thread(runnable, "OpenTelemetry RuntimeMetricsShutdownHook"));
       };
 
   RuntimeMetricsBuilder(OpenTelemetry openTelemetry) {

instrumentation/runtime-telemetry/runtime-telemetry-java8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/RuntimeMetrics.java

@@ -14,7 +14,7 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
-/** The entry point class for runtime metrics support using JFR and JMX. */
+/** The entry point class for runtime metrics support using JMX. */
 public final class RuntimeMetrics implements Closeable {
 
   private static final Logger logger = Logger.getLogger(RuntimeMetrics.class.getName());
@@ -29,7 +29,7 @@ public final class RuntimeMetrics implements Closeable {
   /**
    * Create and start {@link RuntimeMetrics}.
    *
-   * <p>Listens for select JFR events, extracts data, and records to various metrics. Recording will
+   * <p>Listens for select JMX beans, extracts data, and records to various metrics. Recording will
    * continue until {@link #close()} is called.
    *
    * @param openTelemetry the {@link OpenTelemetry} instance used to record telemetry
@@ -47,7 +47,7 @@ public static RuntimeMetricsBuilder builder(OpenTelemetry openTelemetry) {
     return new RuntimeMetricsBuilder(openTelemetry);
   }
 
-  /** Stop recording JFR events. */
+  /** Stop recording JMX metrics. */
   @Override
   public void close() {
     if (!isClosed.compareAndSet(false, true)) {

instrumentation/runtime-telemetry/runtime-telemetry-java8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/RuntimeMetricsBuilder.java

@@ -20,7 +20,7 @@ public final class RuntimeMetricsBuilder {
   private boolean enableExperimentalJmxTelemetry = false;
   private Consumer<Runnable> shutdownHook =
       runnable -> {
-        Runtime.getRuntime().addShutdownHook(new Thread(runnable, "RuntimeMetricsShutdownHook"));
+        Runtime.getRuntime().addShutdownHook(new Thread(runnable, "OpenTelemetry RuntimeMetricsShutdownHook"));
       };
 
   RuntimeMetricsBuilder(OpenTelemetry openTelemetry) {
@@ -49,10 +49,6 @@ public RuntimeMetricsBuilder setShutdownHook(Consumer<Runnable> shutdownHook) {
   }
 
   public void startFromInstrumentationConfig(InstrumentationConfig config) {
-    /*
-    By default, don't use any JFR metrics. May change this once semantic conventions are updated.
-    If enabled, default to only the metrics not already covered by runtime-telemetry-java8
-    */
     boolean defaultEnabled = config.getBoolean("otel.instrumentation.common.default-enabled", true);
     if (!config.getBoolean("otel.instrumentation.runtime-telemetry.enabled", defaultEnabled)) {
       // nothing is enabled

smoke-tests-otel-starter/spring-boot-3/build.gradle.kts

@@ -67,7 +67,7 @@ graalvmNative {
     buildArgs.add("--initialize-at-build-time=org.junit.platform.launcher.core.LauncherConfig")
     buildArgs.add("--initialize-at-build-time=org.junit.jupiter.engine.config.InstantiatingConfigurationParameterConverter")
 
-    // enable JFR - see https://www.graalvm.org/22.0/reference-manual/native-image/JFR/
+    // enable JFR - see https://www.graalvm.org/latest/reference-manual/native-image/debugging-and-diagnostics/JFR/
     buildArgs.add("--enable-monitoring=jfr")
   }