Skip to content

Commit 6b654cf

Browse files
committed
sync more with last release
1 parent 77aa6fb commit 6b654cf

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientAttributesGetter.java

+5-6
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,14 @@ public interface DbClientAttributesGetter<REQUEST> extends DbClientCommonAttribu
2727
@Nullable
2828
String getDbNamespace(REQUEST request);
2929

30+
// TODO (trask) add default implementation that returns null
3031
@Nullable
31-
default String getDbQueryText(REQUEST request) {
32-
return null;
33-
}
32+
String getDbQueryText(REQUEST request);
3433

34+
// TODO (trask) add default implementation that returns null
35+
// after https://github.com/open-telemetry/semantic-conventions/pull/1566
3536
@Nullable
36-
default String getDbOperationName(REQUEST request) {
37-
return null;
38-
}
37+
String getDbOperationName(REQUEST request);
3938

4039
/**
4140
* @deprecated Use {@link #getDbSystem(Object)} instead.

0 commit comments

Comments
 (0)