Update AbstractJdkHttpServerTest.java

SentryMan · SentryMan · commit 6d5e2407cab7 · 2025-02-09T16:53:36.000-05:00
diff --git a/instrumentation/java-http-server/testing/src/main/java/io/opentelemetry/instrumentation/httpserver/AbstractJdkHttpServerTest.java b/instrumentation/java-http-server/testing/src/main/java/io/opentelemetry/instrumentation/httpserver/AbstractJdkHttpServerTest.java
@@ -177,6 +177,7 @@ protected HttpServer setupServer() throws IOException {
 
   @Override
   protected void stopServer(HttpServer server) {
+    //I guess the server has trouble stopping?
     CompletableFuture.runAsync(() -> server.stop(1000));
   }
 
@@ -195,7 +196,6 @@ public void doFilter(HttpExchange exchange, Chain chain) throws IOException {
 
       if (!Span.current().getSpanContext().isValid()) {
         // Return an invalid code to fail any assertion
-
         exchange.sendResponseHeaders(601, -1);
       }
 

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,7 @@ protected HttpServer setupServer() throws IOException {`
`177`	`177`
`178`	`178`	`@Override`
`179`	`179`	`protected void stopServer(HttpServer server) {`
	`180`	`+ //I guess the server has trouble stopping?`
`180`	`181`	`CompletableFuture.runAsync(() -> server.stop(1000));`
`181`	`182`	`}`
`182`	`183`
`@@ -195,7 +196,6 @@ public void doFilter(HttpExchange exchange, Chain chain) throws IOException {`
`195`	`196`
`196`	`197`	`if (!Span.current().getSpanContext().isValid()) {`
`197`	`198`	`// Return an invalid code to fail any assertion`
`198`		`-`
`199`	`199`	`exchange.sendResponseHeaders(601, -1);`
`200`	`200`	`}`
`201`	`201`