sync

anuraaga · anuraaga · commit 7bbc4b3d49bf · 2025-03-10T09:58:57.000+09:00
diff --git a/instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/genai/GenAiAttributesGetter.java b/instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/genai/GenAiAttributesGetter.java
@@ -50,7 +50,6 @@ public interface GenAiAttributesGetter<REQUEST, RESPONSE> {
   @Nullable
   Double getRequestTopP(REQUEST request);
 
-  @Nullable
   List<String> getResponseFinishReasons(REQUEST request, RESPONSE response);
 
   @Nullable
diff --git a/instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/BedrockRuntimeAttributesGetter.java b/instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/BedrockRuntimeAttributesGetter.java
@@ -114,7 +114,6 @@ public Double getRequestTopP(ExecutionAttributes executionAttributes) {
     return BedrockRuntimeAccess.getTopP(executionAttributes.getAttribute(SDK_REQUEST_ATTRIBUTE));
   }
 
-  @Nullable
   @Override
   public List<String> getResponseFinishReasons(
       ExecutionAttributes executionAttributes, @Nullable Response response) {

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,6 @@ public Double getRequestTopP(ExecutionAttributes executionAttributes) {`
`114`	`114`	`return BedrockRuntimeAccess.getTopP(executionAttributes.getAttribute(SDK_REQUEST_ATTRIBUTE));`
`115`	`115`	`}`
`116`	`116`
`117`		`- @Nullable`
`118`	`117`	`@Override`
`119`	`118`	`public List<String> getResponseFinishReasons(`
`120`	`119`	`ExecutionAttributes executionAttributes, @Nullable Response response) {`