Skip to content

Commit 7de6be0

Browse files
committed
address more comments
1 parent 4530a63 commit 7de6be0

File tree

4 files changed

+1
-12
lines changed

4 files changed

+1
-12
lines changed

instrumentation/java-http-server/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/httpserver/ResponseCustomizingFilter.java

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ class ResponseCustomizingFilter extends Filter {
1717

1818
@Override
1919
public void doFilter(HttpExchange exchange, Chain chain) throws IOException {
20-
2120
Context context = Context.current();
2221
HttpServerResponseCustomizerHolder.getCustomizer()
2322
.customize(context, exchange.getResponseHeaders(), JavaHttpResponseMutator.INSTANCE);

instrumentation/java-http-server/library/build.gradle.kts

-6
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,3 @@ plugins {
66
dependencies {
77
testImplementation(project(":instrumentation:java-http-server:testing"))
88
}
9-
10-
tasks {
11-
withType<Test>().configureEach {
12-
systemProperty("testLatestDeps", findProperty("testLatestDeps") as Boolean)
13-
}
14-
}

instrumentation/java-http-server/library/src/main/java/io/opentelemetry/instrumentation/httpserver/OpenTelemetryFilter.java

-2
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,11 @@ final class OpenTelemetryFilter extends Filter {
1818
private final Instrumenter<HttpExchange, HttpExchange> instrumenter;
1919

2020
OpenTelemetryFilter(Instrumenter<HttpExchange, HttpExchange> instrumenter) {
21-
2221
this.instrumenter = instrumenter;
2322
}
2423

2524
@Override
2625
public void doFilter(HttpExchange exchange, Chain chain) throws IOException {
27-
2826
Context parentContext = Context.current();
2927
if (!instrumenter.shouldStart(parentContext, exchange)) {
3028
chain.doFilter(exchange);

instrumentation/java-http-server/testing/src/main/java/io/opentelemetry/instrumentation/httpserver/AbstractJdkHttpServerTest.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ static void sendResponse(
6161
}
6262
}
6363

64-
public String getUrlQuery(HttpExchange exchange) {
64+
private static String getUrlQuery(HttpExchange exchange) {
6565
return exchange.getRequestURI().getQuery();
6666
}
6767

@@ -195,8 +195,6 @@ public void doFilter(HttpExchange exchange, Chain chain) throws IOException {
195195

196196
exchange.sendResponseHeaders(601, -1);
197197
}
198-
exchange.getResponseHeaders().set("decoratingfunction", "ok");
199-
exchange.getResponseHeaders().set("decoratinghttpservicefunction", "ok");
200198

201199
try {
202200
chain.doFilter(exchange);

0 commit comments

Comments
 (0)