Skip to content

Commit 84f2724

Browse files
authored
Make rocketmq span status extractor delegate to default extractor (#12183)
1 parent bed7a6f commit 84f2724

File tree

1 file changed

+5
-1
lines changed
  • instrumentation/rocketmq/rocketmq-client/rocketmq-client-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rocketmqclient/v5_0

1 file changed

+5
-1
lines changed

instrumentation/rocketmq/rocketmq-client/rocketmq-client-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/rocketmqclient/v5_0/RocketMqInstrumenterFactory.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import io.opentelemetry.instrumentation.api.instrumenter.InstrumenterBuilder;
1818
import io.opentelemetry.instrumentation.api.instrumenter.SpanKindExtractor;
1919
import io.opentelemetry.instrumentation.api.instrumenter.SpanLinksExtractor;
20+
import io.opentelemetry.instrumentation.api.instrumenter.SpanStatusExtractor;
2021
import io.opentelemetry.instrumentation.api.internal.PropagatorBasedSpanLinksExtractor;
2122
import java.util.List;
2223
import org.apache.rocketmq.client.apis.consumer.ConsumeResult;
@@ -86,8 +87,11 @@ public static Instrumenter<MessageView, ConsumeResult> createConsumerProcessInst
8687
.addAttributesExtractor(RocketMqConsumerProcessAttributeExtractor.INSTANCE)
8788
.setSpanStatusExtractor(
8889
(spanStatusBuilder, messageView, consumeResult, error) -> {
89-
if (error != null || consumeResult == ConsumeResult.FAILURE) {
90+
if (consumeResult == ConsumeResult.FAILURE) {
9091
spanStatusBuilder.setStatus(StatusCode.ERROR);
92+
} else {
93+
SpanStatusExtractor.getDefault()
94+
.extract(spanStatusBuilder, messageView, consumeResult, error);
9195
}
9296
});
9397

0 commit comments

Comments
 (0)