Skip to content

Commit 86b17eb

Browse files
committed
error.type and db.response.status_code all dbs
1 parent 885514a commit 86b17eb

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

instrumentation/elasticsearch/elasticsearch-transport-common/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/AbstractElasticsearchNodeClientTest.java

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import static io.opentelemetry.api.common.AttributeKey.stringKey;
1010
import static io.opentelemetry.instrumentation.testing.junit.db.SemconvStabilityUtil.maybeStable;
1111
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
12+
import static io.opentelemetry.semconv.ErrorAttributes.ERROR_TYPE;
1213
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_OPERATION;
1314
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_SYSTEM;
1415
import static org.assertj.core.api.Assertions.assertThat;
@@ -123,6 +124,7 @@ void elasticsearchError(Runnable action) {
123124
maybeStable(DB_SYSTEM),
124125
DbIncubatingAttributes.DbSystemIncubatingValues.ELASTICSEARCH),
125126
equalTo(maybeStable(DB_OPERATION), "GetAction"),
127+
equalTo(ERROR_TYPE, "org.elasticsearch.index.IndexNotFoundException"),
126128
equalTo(ELASTICSEARCH_ACTION, "GetAction"),
127129
equalTo(ELASTICSEARCH_REQUEST, "GetRequest"),
128130
equalTo(ELASTICSEARCH_REQUEST_INDICES, "invalid-index")),

instrumentation/lettuce/lettuce-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceAsyncClientTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ void testCommandCompletesExceptionally() {
425425
equalTo(maybeStable(DB_SYSTEM), "redis"),
426426
equalTo(maybeStable(DB_STATEMENT), "DEL key1 key2"),
427427
equalTo(maybeStable(DB_OPERATION), "DEL"),
428-
equalTo(maybeStable(ERROR_TYPE), "java.lang.IllegalStateException"))));
428+
equalTo(ERROR_TYPE, "java.lang.IllegalStateException"))));
429429
}
430430

431431
@Test

0 commit comments

Comments
 (0)