Skip to content

Commit 99ab78c

Browse files
authored
cleanup log filter (#11719)
1 parent a3ec307 commit 99ab78c

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

smoke-tests-otel-starter/spring-smoke-testing/src/main/java/io/opentelemetry/spring/smoketest/AbstractSpringStarterSmokeTest.java

+11-5
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
import static org.assertj.core.api.Assertions.assertThat;
99

1010
import io.opentelemetry.api.OpenTelemetry;
11+
import java.util.Arrays;
12+
import java.util.List;
1113
import org.junit.jupiter.api.AfterEach;
1214
import org.junit.jupiter.api.BeforeAll;
1315
import org.junit.jupiter.api.BeforeEach;
@@ -19,6 +21,11 @@
1921
@ExtendWith(OutputCaptureExtension.class)
2022
public abstract class AbstractSpringStarterSmokeTest {
2123

24+
private static final List<String> IGNORED_WARNINGS =
25+
Arrays.asList(
26+
"Unable to load io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider",
27+
"The architecture 'amd64' for image");
28+
2229
@Autowired protected OpenTelemetry openTelemetry;
2330

2431
protected SpringSmokeTestRunner testing;
@@ -47,11 +54,10 @@ void checkSpringLogs(CapturedOutput output) {
4754
// only look for WARN and ERROR log level, e.g. [Test worker] WARN
4855
.satisfies(
4956
s -> {
50-
if (!s.toString()
51-
.contains(
52-
"Unable to load io.netty.resolver.dns.macos.MacOSDnsServerAddressStreamProvider")
53-
&& !s.toString().contains("The architecture 'amd64' for image")) {
54-
assertThat(s).doesNotContain("] WARN").doesNotContain("] ERROR");
57+
for (String line : s.toString().split("\n")) {
58+
if (IGNORED_WARNINGS.stream().noneMatch(line::contains)) {
59+
assertThat(line).doesNotContain("] WARN").doesNotContain("] ERROR");
60+
}
5561
}
5662
});
5763
}

0 commit comments

Comments
 (0)