Skip to content

Commit a07317e

Browse files
committed
PR comments addressed
1 parent 7bf1776 commit a07317e

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

instrumentation/activej-http-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerHttpAttributesGetter.java

-4
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,4 @@ public String getNetworkProtocolVersion(
6363
return ActivejHttpServerUtil.getNetworkProtocolVersion(request.getVersion());
6464
}
6565

66-
@Override
67-
public String getHttpRoute(HttpRequest request) {
68-
return request.getPath();
69-
}
7066
}

instrumentation/activej-http-6.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/activejhttp/ActivejRoutingServletTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ void testRequestSuccessFlow() throws Exception {
5757
trace ->
5858
trace.hasSpansSatisfyingExactly(
5959
span ->
60-
span.hasName("GET /success")
60+
span.hasName("GET")
6161
.hasNoParent()
6262
.hasKind(SpanKind.SERVER)
6363
.hasAttributesSatisfying(
@@ -84,7 +84,7 @@ void testRequestNotFoundFlow() throws Exception {
8484
trace ->
8585
trace.hasSpansSatisfyingExactly(
8686
span ->
87-
span.hasName("GET /notfound")
87+
span.hasName("GET")
8888
.hasNoParent()
8989
.hasKind(SpanKind.SERVER)
9090
.hasAttributesSatisfying(

0 commit comments

Comments
 (0)