Skip to content

Commit a3b0e31

Browse files
authored
Enable running with indy for jodd-http-4.2 (#9898)
1 parent 9fb5b3f commit a3b0e31

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
plugins {
2+
id("otel.java-conventions")
3+
}
4+
5+
dependencies {
6+
testImplementation("org.jodd:jodd-http:4.2.0")
7+
testImplementation(project(":instrumentation:jodd-http-4.2:javaagent"))
8+
testImplementation(project(":instrumentation-api"))
9+
testImplementation(project(":instrumentation-api-semconv"))
10+
}

instrumentation/jodd-http-4.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/joddhttp/v4_2/JoddHttpInstrumentationModule.java

-7
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,6 @@ public JoddHttpInstrumentationModule() {
1818
super("jodd-http", "jodd-http-4.2");
1919
}
2020

21-
@Override
22-
public boolean isIndyModule() {
23-
// JoddHttpHttpAttributesGetterTest is not an agent test, with indy it can't access
24-
// JoddHttpHttpAttributesGetter
25-
return false;
26-
}
27-
2821
@Override
2922
public List<TypeInstrumentation> typeInstrumentations() {
3023
return Collections.singletonList(new JoddHttpInstrumentation());

settings.gradle.kts

+1
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ include(":instrumentation:jms:jms-common:javaagent-unit-tests")
324324
include(":instrumentation:jmx-metrics:javaagent")
325325
include(":instrumentation:jmx-metrics:library")
326326
include(":instrumentation:jodd-http-4.2:javaagent")
327+
include(":instrumentation:jodd-http-4.2:javaagent-unit-tests")
327328
include(":instrumentation:jsf:jsf-javax-common:javaagent")
328329
include(":instrumentation:jsf:jsf-javax-common:testing")
329330
include(":instrumentation:jsf:jsf-jakarta-common:javaagent")

0 commit comments

Comments
 (0)