always need map converter

Author: zeitlinger

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java

@@ -57,18 +57,20 @@ public class OpenTelemetryAutoConfiguration {
 
   public OpenTelemetryAutoConfiguration() {}
 
+  @Bean
+  @ConfigurationPropertiesBinding
+  public MapConverter mapConverter() {
+    // needed for otlp exporter headers and OtelResourceProperties
+    // we need this converter, even if the SDK is disabled,
+    // because the properties are parsed before the SDK is disabled
+    return new MapConverter();
+  }
+
   @Configuration
   @Conditional(SdkEnabled.class)
   @ConditionalOnMissingBean(OpenTelemetry.class)
   static class OpenTelemetrySdkConfig {
 
-    @Bean
-    @ConfigurationPropertiesBinding
-    public MapConverter mapConverter() {
-      // needed for otlp exporter headers and OtelResourceProperties
-      return new MapConverter();
-    }
-
     @Bean
     public OpenTelemetrySdkComponentLoader openTelemetrySdkComponentLoader(
         ApplicationContext applicationContext) {

instrumentation/spring/spring-boot-autoconfigure/src/test/java/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfigurationTest.java

@@ -156,7 +156,9 @@ void shouldInitializeSdkWhenNotDisabled() {
   void shouldInitializeNoopOpenTelemetryWhenSdkIsDisabled() {
     this.contextRunner
         .withConfiguration(AutoConfigurations.of(OpenTelemetryAutoConfiguration.class))
-        .withPropertyValues("otel.sdk.disabled=true")
+        .withPropertyValues(
+            "otel.sdk.disabled=true",
+            "otel.resource.attributes=service.name=workflow-backend-dev,service.version=3c8f9ce9")
         .run(
             context ->
                 assertThat(context).getBean("openTelemetry").isEqualTo(OpenTelemetry.noop()));