Use AttributeKey

Author: luke-sterkowicz

instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/TracingClientInterceptor.java

@@ -26,6 +26,10 @@
 
 final class TracingClientInterceptor implements ClientInterceptor {
 
+  private static final AttributeKey<Long> GRPC_MESSAGES_RECEIVED =
+      AttributeKey.longKey("grpc.messages.received");
+  private static final AttributeKey<Long> GRPC_MESSAGES_SENT =
+      AttributeKey.longKey("grpc.messages.sent");
   // copied from MessageIncubatingAttributes
   private static final AttributeKey<Long> MESSAGE_ID = AttributeKey.longKey("message.id");
   private static final AttributeKey<String> MESSAGE_TYPE = AttributeKey.stringKey("message.type");
@@ -171,9 +175,9 @@ public void onClose(Status status, Metadata trailers) {
         if (captureExperimentalSpanAttributes) {
           Span span = Span.fromContext(context);
           span.setAttribute(
-              "grpc.messages.received", RECEIVED_MESSAGE_ID_UPDATER.get(TracingClientCall.this));
+              GRPC_MESSAGES_RECEIVED, RECEIVED_MESSAGE_ID_UPDATER.get(TracingClientCall.this));
           span.setAttribute(
-              "grpc.messages.sent", SENT_MESSAGE_ID_UPDATER.get(TracingClientCall.this));
+              GRPC_MESSAGES_SENT, SENT_MESSAGE_ID_UPDATER.get(TracingClientCall.this));
         }
         instrumenter.end(context, request, status, status.getCause());
         try (Scope ignored = parentContext.makeCurrent()) {

instrumentation/grpc-1.6/library/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/TracingServerInterceptor.java

@@ -25,6 +25,12 @@
 
 final class TracingServerInterceptor implements ServerInterceptor {
 
+  private static final AttributeKey<Boolean> GRPC_CANCELED =
+      AttributeKey.booleanKey("grpc.canceled");
+  private static final AttributeKey<Long> GRPC_MESSAGES_RECEIVED =
+      AttributeKey.longKey("grpc.messages.received");
+  private static final AttributeKey<Long> GRPC_MESSAGES_SENT =
+      AttributeKey.longKey("grpc.messages.sent");
   // copied from MessageIncubatingAttributes
   private static final AttributeKey<Long> MESSAGE_ID = AttributeKey.longKey("message.id");
   private static final AttributeKey<String> MESSAGE_TYPE = AttributeKey.stringKey("message.type");
@@ -151,11 +157,11 @@ private void end(Context context, GrpcRequest request, Status response, Throwabl
         if (captureExperimentalSpanAttributes) {
           Span span = Span.fromContext(context);
           span.setAttribute(
-              "grpc.messages.received", RECEIVED_MESSAGE_ID_UPDATER.get(TracingServerCall.this));
+              GRPC_MESSAGES_RECEIVED, RECEIVED_MESSAGE_ID_UPDATER.get(TracingServerCall.this));
           span.setAttribute(
-              "grpc.messages.sent", SENT_MESSAGE_ID_UPDATER.get(TracingServerCall.this));
+              GRPC_MESSAGES_SENT, SENT_MESSAGE_ID_UPDATER.get(TracingServerCall.this));
           if (Status.CANCELLED.equals(status)) {
-            span.setAttribute("grpc.canceled", true);
+            span.setAttribute(GRPC_CANCELED, true);
           }
         }
         instrumenter.end(context, request, response, error);